[Meta] Custom Tab Support

[bbinto]

Why/User Benefit/User Problem

As a user I want to be able to tap on a link within an app, launch a site with my default browser (Fenix) without leaving the app, and close the site to return to the app.

What / Requirements

UI mockups
~~Android Component: https://github.com/mozilla~~mobile/android-components/issues/1398

Acceptance Criteria (how do I know when I’m done?)

-Customizable tab allowing to add toolbarcolour and menu items.
Allow for prestarting Fenix and pre-fetching content for faster loading.

┆Issue is synchronized with this Jira Task

[jonalmeida]

The original link was pointing to a sub-task for an r-b user story (which is similar-ish to a meta): mozilla-mobile/reference-browser#137

[bbinto]

Need to chat with UX (@lime124) if we need any specific UX for this or can we use what A/C has done, @st3fan should have a bit more information

[st3fan]

It is best to look at the Reference Browser to see the current UI to find out if that is adequate for a first release. There are probably some limitations about what we can do UI-wise I think, so we definitely need to get together to look at current and wanted designs.

[bbinto]

Feature parity to Focus (minus the issues)

[bbinto]

UX to confirm how this will work for sessions
(cc @lime124 )

[shorlander]

It is best to look at the Reference Browser to see the current UI to find out if that is adequate for a first release. There are probably some limitations about what we can do UI-wise I think, so we definitely need to get together to look at current and wanted designs.

When I try and use the Reference Browser for this it just loads the link in the browser. Not a Custom Tab.

@st3fan am I doing something wrong?

[jonalmeida]

@shorlander Sorry about that, Custom Tabs hasn't landed in the Reference Browser because of an integration bug that I'm currently looking into (see: mozilla-mobile/reference-browser#487).

[jonalmeida]

@shorlander Custom Tabs has landed in R-B so feel free to have a look.

[st3fan]

@shorlander a good app to test this with is the official Reddit app. Custom Tabs should open with a blue location bar. Another app where this works well is GMail, which should open up a tab with a red location bar.

I don't think Twitter properly supports this - it seems links from Twitter are opened directly in the R-B by switching apps not by opening a custom tab.

[sblatz]

As a part of this, let's make sure we test our menu options work properly in a custom tab. Find in page and request desktop site do not function correctly as is.

Breakout ticket: #1007

[bbinto]

I remember @vesta0 mentioning we had some custom tabs issue in Focus, let's make sure we are addressing them / being aware of them for Fenix as well.

[jonalmeida]

As a part of this, let's make sure we test our menu options work properly in a custom tab. Find in page and request desktop site do not function correctly as is.

I've filed an issue for this: mozilla-mobile/android-components#2387

[vesta0]

All issues listed under this meta have been implemented.