Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Change menu for Custom Tabs #832

Closed
sblatz opened this issue Mar 4, 2019 · 3 comments
Closed

Change menu for Custom Tabs #832

sblatz opened this issue Mar 4, 2019 · 3 comments
Assignees
@sblatz
Labels
Feature:CustomTabs
Milestone
Sprint 3-2 (Miles...

Comments

@sblatz
Copy link
Contributor

sblatz commented Mar 4, 2019 •
edited by data-sync-user
Loading

When we open a custom tab from certain apps, our menu is overridden (for example in Slack it presents a few options like "Share in Slack"). However in other apps (like Yelp) our normal menu is inflated. We should decide if we want to hide our menu button if the custom tab app is not overriding the behavior

┆Issue is synchronized with this Jira Task
@vesta0
Copy link
Collaborator

vesta0 commented Mar 5, 2019

Should be a custom menu (Mocks in #203)

@sblatz sblatz changed the title Decide behavior for custom tab menu Change menu for Custom Tabs Mar 5, 2019
@vesta0 vesta0 added this to the Sprint 3-1 (Milestone 3) milestone Mar 5, 2019
@vesta0 vesta0 added the size S label Mar 5, 2019
@sblatz sblatz self-assigned this Mar 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Mar 11, 2019
@sblatz
Closes mozilla-mobile#832: Adds custom tabs menu
5f8d5f6
sblatz added a commit to sblatz/fenix that referenced this issue Mar 11, 2019
@sblatz
Closes mozilla-mobile#832: Adds custom tabs menu
0bf5f73
@ghost ghost added in progress labels Mar 11, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Mar 12, 2019
@sblatz
Closes mozilla-mobile#832: Adds custom tabs menu
6f0e83f
@sblatz sblatz closed this as completed in 33b83fb Mar 13, 2019
@ghost ghost removed in progress labels Mar 13, 2019
@bsurd
Copy link

bsurd commented Mar 14, 2019

Could still reproduce the Slack issue on:

  • Google Pixel (Android 9)
  • Nexus 5 (Android 6.0.1)
  • Build: 1.0.1911 (#10731207)
  • Logcat
  • Video

The issue is not reproducible on Samsung Galaxy Note 8 (Android 9). Reopening.

@bsurd bsurd reopened this Mar 14, 2019
@sblatz
Copy link
Contributor Author

sblatz commented Mar 14, 2019 •
edited
Loading

Did some more investigation. Looks like this is the behavior that Focus has as well, but it does not happen in other browsers including Fennec & reference browser, so I will start there with implementing a solution for all devices!

sblatz added a commit to sblatz/fenix that referenced this issue Mar 14, 2019
@sblatz
Closes mozilla-mobile#832 & For mozilla-mobile#222: Adds basic custom…
20bbd9e 
… tab integration
sblatz added a commit to sblatz/fenix that referenced this issue Mar 14, 2019
@sblatz
Closes mozilla-mobile#832 & For mozilla-mobile#222: Adds basic custom…
e8fa7b9 
… tab integration
sblatz added a commit to sblatz/fenix that referenced this issue Mar 14, 2019
@sblatz
Closes mozilla-mobile#832 & For mozilla-mobile#222: Adds basic custom…
33a2bc7 
… tab integration
@ghost ghost added in progress labels Mar 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Mar 14, 2019
@sblatz
Closes mozilla-mobile#832 & For mozilla-mobile#222: Adds basic custom…
26bafd0 
… tab integration
@sblatz sblatz added 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Mar 14, 2019
@sblatz sblatz added 🙅 waiting Issues that are blocked or has dependencies that are not ready in progress and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready in progress labels Mar 14, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Mar 15, 2019
@sblatz
Closes mozilla-mobile#832 & For mozilla-mobile#222: Adds basic custom…
3807b89 
… tab integration
sblatz added a commit to sblatz/fenix that referenced this issue Mar 15, 2019
@sblatz
Closes mozilla-mobile#832 & For mozilla-mobile#222: Adds basic custom…
e6b9e69 
… tab integration
@sblatz sblatz closed this as completed in 8620b78 Mar 15, 2019
@ghost ghost removed in progress labels Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sblatz sblatz

Labels
Feature:CustomTabs
Projects
None yet
Milestone
Sprint 3-2 (Milestone 3)
Development

No branches or pull requests
4 participants
@sblatz @bsurd @vesta0 @bifleming