Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Specify fetchProvidedTopSites parameter for TopSitesConfig #23409

Closed
gabrielluong opened this issue Jan 25, 2022 · 0 comments · Fixed by #23410
Closed

Specify fetchProvidedTopSites parameter for TopSitesConfig #23409

gabrielluong opened this issue Jan 25, 2022 · 0 comments · Fixed by #23410
Assignees
@gabrielluong
Labels
Feature:Shortcuts Top Sites/Topsites on the Firefox home page
Milestone
98

Comments

@gabrielluong
Copy link
Member

gabrielluong commented Jan 25, 2022 •
edited
Loading

In mozilla-mobile/android-components#11605, we added a parameter to specify whether or not we should fetch top sites from a TopSitesProvider. To fix the breaking change, we need to specify a fetchProvidedTopSites parameter to our existing TopSitesConfig with the intention of only fetching Contile Top Sites when the preference is set.
@gabrielluong gabrielluong added the Feature:Shortcuts Top Sites/Topsites on the Firefox home page label Jan 25, 2022
@gabrielluong gabrielluong added this to the 98 milestone Jan 25, 2022
@gabrielluong gabrielluong self-assigned this Jan 25, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 25, 2022
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Jan 25, 2022
@gabrielluong gabrielluong mentioned this issue Jan 25, 2022
Merged
4 tasks
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 25, 2022
@gabrielluong
For mozilla-mobile#23409 - Specify fetchProvidedTopSites parameter fo…
1171540 
…r TopSitesConfig
@gabrielluong gabrielluong mentioned this issue Jan 25, 2022
Merged
3 tasks
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jan 26, 2022
@gabrielluong
For mozilla-mobile#23409 - Specify fetchProvidedTopSites parameter fo…
7386a7d 
…r TopSitesConfig
@mergify mergify bot closed this as completed in #23410 Jan 26, 2022
mergify bot pushed a commit that referenced this issue Jan 26, 2022
@gabrielluong @mergify
For #23409 - Specify fetchProvidedTopSites parameter for TopSitesConfig
e5e7e6d
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 9, 2022
@gabrielluong @pkirakosyan
For mozilla-mobile#23409 - Specify fetchProvidedTopSites parameter fo…
e641bec 
…r TopSitesConfig
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
Feature:Shortcuts Top Sites/Topsites on the Firefox home page
Projects
None yet
Milestone
98
Development

Successfully merging a pull request may close this issue.

For #23409 - Specify fetchProvidedTopSites parameter for TopSitesConfig gabrielluong/fenix
1 participant
@gabrielluong