Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #23409 - Specify fetchProvidedTopSites parameter for TopSitesConfig #23410

Merged
merged 2 commits into from
Jan 26, 2022
Merged

For #23409 - Specify fetchProvidedTopSites parameter for TopSitesConfig #23410

merged 2 commits into from
Jan 26, 2022

Conversation

gabrielluong
Copy link
Member

@gabrielluong gabrielluong commented Jan 25, 2022 •
edited
Loading

Fixes #23409. Needs AC bump with mozilla-mobile/android-components#11605.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@gabrielluong gabrielluong added the pr:needs-ac-bump PR that needs a AC bump label Jan 25, 2022
@gabrielluong gabrielluong requested review from a team as code owners January 25, 2022 21:58
@gabrielluong gabrielluong removed the pr:needs-ac-bump PR that needs a AC bump label Jan 26, 2022
@gabrielluong gabrielluong added the needs:review PRs that need to be reviewed label Jan 26, 2022
@gabrielluong gabrielluong mentioned this pull request Jan 26, 2022
Closed
@gabrielluong gabrielluong added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Jan 26, 2022
@mergify mergify bot merged commit e5e7e6d into mozilla-mobile:main Jan 26, 2022
@gabrielluong gabrielluong deleted the 23409 branch January 26, 2022 05:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonalmeida jonalmeida jonalmeida approved these changes

@MozillaNoah MozillaNoah Awaiting requested review from MozillaNoah

Assignees
No one assigned
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify fetchProvidedTopSites parameter for TopSitesConfig
2 participants
@gabrielluong @jonalmeida