Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Make expiring performance telemetry permanent (Feb 2022) #23426

Closed
mcomella opened this issue Jan 26, 2022 · 3 comments · Fixed by #23506 or #23515
Closed

Make expiring performance telemetry permanent (Feb 2022) #23426

mcomella opened this issue Jan 26, 2022 · 3 comments · Fixed by #23506 or #23515
Assignees
Labels
performance Possible performance wins

Comments

@mcomella
Copy link
Contributor

mcomella commented Jan 26, 2022

Let's change the performance telemetry probes (if relevant) to be permanent fixtures rather than renewing. This assumes they don't affect performance and they don't have privacy implications.

Note: the fenix team has a renewal ticket in #22870.

┆Issue is synchronized with this Jira Task

@mcomella mcomella added the performance Possible performance wins label Jan 26, 2022
@mcomella mcomella changed the title Expiring telemetry probes. Piggy back on https://github.com/mozilla-mobile/fenix/issues/22870 ? Make expiring performance telemetry permanent (Feb 2022) Jan 26, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jan 26, 2022
@mcomella
Copy link
Contributor Author

Data renewal request: https://github.com/mozilla/data-review/blob/main/renewal_request.md

And we need to change the metrics.yaml so they don't expire too. This needs to land before Feb. 1.

@mcomella mcomella removed the needs:triage Issue needs triage label Jan 26, 2022
@eliserichards
Copy link

@MarcLeclair you can tag me or @rocketsroger for data reviews on this :)

@eliserichards
Copy link

Any updates on this? 👀

MarcLeclair pushed a commit to MarcLeclair/fenix that referenced this issue Jan 31, 2022
MarcLeclair pushed a commit to MarcLeclair/fenix that referenced this issue Jan 31, 2022
mergify bot pushed a commit that referenced this issue Feb 1, 2022
mergify bot pushed a commit that referenced this issue Feb 1, 2022
added new data_review url

(cherry picked from commit 2fb8d88)

# Conflicts:
#	app/metrics.yaml
eliserichards pushed a commit to eliserichards/fenix that referenced this issue Feb 1, 2022
eliserichards pushed a commit that referenced this issue Feb 1, 2022
added new data_review url

Co-authored-by: Marc-Andre Leclair <mleclair@Marc-Andres-MBP.lan>
pkirakosyan pushed a commit to gexsi/user-agent-android that referenced this issue Mar 10, 2022
lillabldv added a commit to karmaSearch/fenix that referenced this issue Mar 26, 2022
* releases_v97.0.0: (455 commits)
  Automatic version bump CLOSED TREE NO BUG a=release
  Bump version to 97.3.0.
  Update to Android-Components 97.0.13.
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 97.0.12.
  Bump version to 97.2.0.
  Automatic version bump CLOSED TREE NO BUG a=release
  Fix signing format for mozillaonline builds (mozilla-mobile#23603)
  Update to Android-Components 97.0.11.
  Automatic version bump CLOSED TREE NO BUG a=release
  Update to Android-Components 97.0.10. (mozilla-mobile#23519)
  Issue mozilla-mobile#22256: Ignore intermittent editCustomSearchEngineTest
  No issue: Update PWA package name in mainMenuInstallPWATest (mozilla-mobile#23335)
  For mozilla-mobile#23426:Changed expiring perf probes to never expire (mozilla-mobile#23515)
  Bump version to 97.1.0.
  [Uplift] For mozilla-mobile#22870: Renew metrics set to expire in February (mozilla-mobile#23496)
  Strings - app/src/main/res/values-zh-rCN/strings.xml
  Strings - app/src/main/res/values-tr/strings.xml
  Strings - app/src/main/res/values-tg/strings.xml
  Strings - app/src/main/res/values-sk/strings.xml
  ...

# Conflicts:
#	app/metrics.yaml
#	app/src/main/java/org/mozilla/fenix/FeatureFlags.kt
#	app/src/main/java/org/mozilla/fenix/FenixApplication.kt
#	app/src/main/java/org/mozilla/fenix/components/Core.kt
#	app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeFragmentStore.kt
#	app/src/main/java/org/mozilla/fenix/home/HomeMenu.kt
#	app/src/main/java/org/mozilla/fenix/home/recentbookmarks/controller/RecentBookmarksController.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlAdapter.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlInteractor.kt
#	app/src/main/java/org/mozilla/fenix/home/sessioncontrol/SessionControlView.kt
#	app/src/main/java/org/mozilla/fenix/home/topsites/TopSiteItemViewHolder.kt
#	app/src/main/java/org/mozilla/fenix/theme/FirefoxTheme.kt
#	app/src/main/res/drawable-xhdpi/ic_logo_wordmark_normal.png
#	app/src/main/res/drawable-xhdpi/ic_logo_wordmark_private.png
#	app/src/main/res/drawable-xxhdpi/ic_logo_wordmark_private.png
#	app/src/main/res/drawable-xxxhdpi/ic_logo_wordmark_private.png
#	app/src/main/res/drawable/ic_baidu.png
#	app/src/main/res/drawable/ic_jd.png
#	app/src/main/res/drawable/ic_pdd.png
#	app/src/main/res/drawable/ic_tc.png
#	app/src/main/res/layout/top_site_item.xml
#	app/src/main/res/values-ar/strings.xml
#	app/src/main/res/values-be/strings.xml
#	app/src/main/res/values-bg/strings.xml
#	app/src/main/res/values-bn/strings.xml
#	app/src/main/res/values-ca/strings.xml
#	app/src/main/res/values-co/strings.xml
#	app/src/main/res/values-cs/strings.xml
#	app/src/main/res/values-cy/strings.xml
#	app/src/main/res/values-da/strings.xml
#	app/src/main/res/values-de/strings.xml
#	app/src/main/res/values-dsb/strings.xml
#	app/src/main/res/values-el/strings.xml
#	app/src/main/res/values-en-rCA/strings.xml
#	app/src/main/res/values-en-rGB/strings.xml
#	app/src/main/res/values-es-rAR/strings.xml
#	app/src/main/res/values-es-rCL/strings.xml
#	app/src/main/res/values-es-rES/strings.xml
#	app/src/main/res/values-es-rMX/strings.xml
#	app/src/main/res/values-es/strings.xml
#	app/src/main/res/values-eu/strings.xml
#	app/src/main/res/values-fa/strings.xml
#	app/src/main/res/values-fi/strings.xml
#	app/src/main/res/values-fr/strings.xml
#	app/src/main/res/values-fy-rNL/strings.xml
#	app/src/main/res/values-gd/strings.xml
#	app/src/main/res/values-gn/strings.xml
#	app/src/main/res/values-hi-rIN/strings.xml
#	app/src/main/res/values-hr/strings.xml
#	app/src/main/res/values-hsb/strings.xml
#	app/src/main/res/values-hu/strings.xml
#	app/src/main/res/values-hy-rAM/strings.xml
#	app/src/main/res/values-ia/strings.xml
#	app/src/main/res/values-in/strings.xml
#	app/src/main/res/values-is/strings.xml
#	app/src/main/res/values-it/strings.xml
#	app/src/main/res/values-iw/strings.xml
#	app/src/main/res/values-ja/strings.xml
#	app/src/main/res/values-ka/strings.xml
#	app/src/main/res/values-kab/strings.xml
#	app/src/main/res/values-kk/strings.xml
#	app/src/main/res/values-kmr/strings.xml
#	app/src/main/res/values-ko/strings.xml
#	app/src/main/res/values-lt/strings.xml
#	app/src/main/res/values-nb-rNO/strings.xml
#	app/src/main/res/values-night/colors.xml
#	app/src/main/res/values-nl/strings.xml
#	app/src/main/res/values-nn-rNO/strings.xml
#	app/src/main/res/values-oc/strings.xml
#	app/src/main/res/values-pa-rIN/strings.xml
#	app/src/main/res/values-pl/strings.xml
#	app/src/main/res/values-pt-rBR/strings.xml
#	app/src/main/res/values-pt-rPT/strings.xml
#	app/src/main/res/values-rm/strings.xml
#	app/src/main/res/values-ru/strings.xml
#	app/src/main/res/values-sat/strings.xml
#	app/src/main/res/values-sk/strings.xml
#	app/src/main/res/values-sl/strings.xml
#	app/src/main/res/values-sq/strings.xml
#	app/src/main/res/values-sr/strings.xml
#	app/src/main/res/values-su/strings.xml
#	app/src/main/res/values-sv-rSE/strings.xml
#	app/src/main/res/values-te/strings.xml
#	app/src/main/res/values-tg/strings.xml
#	app/src/main/res/values-th/strings.xml
#	app/src/main/res/values-tr/strings.xml
#	app/src/main/res/values-tt/strings.xml
#	app/src/main/res/values-uk/strings.xml
#	app/src/main/res/values-ur/strings.xml
#	app/src/main/res/values-uz/strings.xml
#	app/src/main/res/values-vi/strings.xml
#	app/src/main/res/values-zh-rCN/strings.xml
#	app/src/main/res/values-zh-rTW/strings.xml
#	app/src/main/res/values/colors.xml
#	app/src/main/res/values/strings.xml
#	app/src/main/res/values/styles.xml
#	app/src/release/res/drawable-hdpi/fenix_search_widget.png
#	app/src/release/res/mipmap-hdpi/ic_launcher.png
#	app/src/release/res/mipmap-xhdpi/ic_launcher.png
#	app/src/release/res/mipmap-xxhdpi/ic_launcher.png
#	app/src/release/res/mipmap-xxxhdpi/ic_launcher.png
#	app/src/test/java/org/mozilla/fenix/components/history/PagedHistoryProviderTest.kt
#	app/src/test/java/org/mozilla/fenix/home/DefaultSessionControlControllerTest.kt
#	app/src/test/java/org/mozilla/fenix/home/SessionControlInteractorTest.kt
#	app/src/test/java/org/mozilla/fenix/home/recentbookmarks/DefaultRecentBookmarksControllerTest.kt
#	app/src/test/java/org/mozilla/fenix/home/recentvisits/interactor/RecentVisitsInteractorTest.kt
#	app/src/test/java/org/mozilla/fenix/home/sessioncontrol/SessionControlViewTest.kt
#	buildSrc/src/main/java/AndroidComponents.kt
#	version.txt
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
performance Possible performance wins
Projects
None yet
3 participants