Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #23426:Changed expiring perf probes to never expire #23506

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

MarcLeclair
Copy link
Contributor

  1. Provide a link to the initial Data Collection Review Request for this collection:

start_reason_activity_error
start_reason_process_error
application_on_create
cold_main_app_to_first_frame
cold_unknwn_app_to_first_frame
cold_view_app_to_first_frame
app_bytes
cache_bytes
data_dir_bytes
query_stats_duration

  1. When will this collection now expire?

Never

  1. Why was the initial period of collection insufficient?

Since we're trying to continuously improve and track performance of fenix, having an expiry date for these probes doesn't make much sense.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@MarcLeclair MarcLeclair requested review from a team as code owners January 31, 2022 22:39
@rocketsroger
Copy link
Contributor

  1. Provide a link to the initial Data Collection Review Request for this collection:

start_reason_activity_error start_reason_process_error application_on_create cold_main_app_to_first_frame cold_unknwn_app_to_first_frame cold_view_app_to_first_frame app_bytes cache_bytes data_dir_bytes query_stats_duration

2. **When will this collection now expire?**

Never

3. **Why was the initial period of collection insufficient?**

Since we're trying to continuously improve and track performance of fenix, having an expiry date for these probes doesn't make much sense.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rocketsroger rocketsroger added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Jan 31, 2022
@eliserichards
Copy link

eliserichards commented Jan 31, 2022

We'll backport this to v96 and v97 once it's merged 👍

@mergify mergify bot merged commit 2fb8d88 into mozilla-mobile:main Feb 1, 2022
@eliserichards
Copy link

@Mergifyio backport releases_v97.0.0

@mergify
Copy link
Contributor

mergify bot commented Feb 1, 2022

backport releases_v97.0.0

✅ Backports have been created

@eliserichards eliserichards linked an issue Feb 1, 2022 that may be closed by this pull request
@eliserichards
Copy link

Uplift for 97: #23515

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make expiring performance telemetry permanent (Feb 2022)
3 participants