This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #23426:Changed expiring perf probes to never expire #23506
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data Collection Renewal Review
Yes
Yes Resultdata-review+ |
added new data_review url
MarcLeclair
force-pushed
the
23426_probes
branch
from
January 31, 2022 22:54
b27a7f1
to
3140fd0
Compare
rocketsroger
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
rocketsroger
added
the
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
label
Jan 31, 2022
We'll backport this to |
@Mergifyio backport releases_v97.0.0 |
✅ Backports have been created
|
Uplift for 97: #23515 |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start_reason_activity_error
start_reason_process_error
application_on_create
cold_main_app_to_first_frame
cold_unknwn_app_to_first_frame
cold_view_app_to_first_frame
app_bytes
cache_bytes
data_dir_bytes
query_stats_duration
Never
Since we're trying to continuously improve and track performance of fenix, having an expiry date for these probes doesn't make much sense.
Pull Request checklist
To download an APK when reviewing a PR: