For #20519: renew perf telemetry probes (August expiry).

[mcomella]

I used eliserichards' PR #20519 to
renew more easily.

---

Request for Data Collection Renewal

** This form is for the renewal of an existing, reviewed data collection.**

** All questions are mandatory.
You must receive Data Review from a
Data Steward
on a filled-out Request before shipping your renewed data collection.**

1. Provide a link to the initial Data Collection Review Request for this collection.

cold_*_to_first_frame + start_reason_*_error:

• For #18426: add COLD MAIN duration telemetry #18632 (comment)

application_on_create:

• For #17969: add duration probes for App.onCreate and HomeActivity.onC… #17973 (comment)

storage.stats:

• For #12802: add StorageStats glean metrics. #12876 (comment)
• For #17553: renew storage.stats metrics. #17704 (comment)
• For #19923: renew telemetry probes #19924 (comment)

2. When will this collection now expire?

2022-02-01

3. Why was the initial period of collection insufficient?

cold_*_to_first_frame + start_reason_*_error + application_on_create: attempted to analyze the telemetry but it required other telemetry analysis to be performed first and was deferred. It's useful to monitor the perf over time before we attempt to analyze it again.

storage.stats: unclear ownership of probe between fenix and perf team. It's useful to monitor over time though to look for large regressions so we'd like to keep analyzing it.

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[eliserichards]

The following tests were breaking on main, (ignores being added here which is going to land before this) so we should make sure that they are fixed in this PR:

• StorageStatsMetricsTest.WHEN reporting THEN the values from the storageStats are accumulated
• StorageStatsMetricsTest.WHEN reporting THEN the query duration is measured

[boek]

r+

Data Collection Renewal Review (to be filled by Data Stewards)

1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?
   Yes
2. Is the data collection covered by the existing Firefox Privacy Notice?
   Yes

[mcomella]

The following tests were breaking on main, (ignores being added here which is going to land before this) so we should make sure that they are fixed in this PR:

I confirmed the StorageStatsMetrics tests are fixed in my PR through local testing.

[mcomella]

FenixApplicationTest.when setStartupMetrics is called... is not fixed by my test, as suggested by #20616, but the issue seems unrelated to my PR.

[mcomella]

Test failures all look like things that'd be addressed if I rebased so I will rebase and rerun:

    FenixApplicationTest. WHEN setStartupMetrics is called THEN sets some base metrics
    GleanMetricsServiceTest. TabsTray events are correctly recorded
    GleanMetricsServiceTest. awesomebar events are correctly recorded
    GleanMetricsServiceTest. synced tab event is correctly recorded

[mcomella]

Locally, I still get two test failures:

• FenixApplicationTest...
• GleanMetricsService.TabsTray events...

[eliserichards]

These two are fixed in #20621. Once that lands you can rebase and those failures should be resolved 👍

[mcomella]

@Mergifyio rebase

[mergify]

Command rebase: success

Branch has been successfully rebased

[eliserichards]

🙌 🚀

[mcomella]

Unit test failure in HistoryMenuItemTest:

io.mockk.MockKException: Can't instantiate proxy for class kotlin.Function1
	at io.mockk.impl.instantiation.JvmMockFactory.newProxy(JvmMockFactory.kt:64)
	at io.mockk.impl.instantiation.AbstractMockFactory.newProxy$default(AbstractMockFactory.kt:29)

It looks like one of those Java 11 test failures.

[mcomella]

It doesn't fail locally so... re-run?

[mcomella]

Unit test failure in HistoryMenuItemTest:

io.mockk.MockKException: Can't instantiate proxy for class kotlin.Function1
	at io.mockk.impl.instantiation.JvmMockFactory.newProxy(JvmMockFactory.kt:64)
	at io.mockk.impl.instantiation.AbstractMockFactory.newProxy$default(AbstractMockFactory.kt:29)

It looks like one of those Java 11 test failures.

I filed #20627

[eliserichards]

@Mergifyio backport releases_v91.0.0

[mergify]

Command backport releases_v91.0.0: success

Backports have been created

• #21020 For #20519: renew perf telemetry probes (August expiry). (backport #20623) has been created for branch releases_v91.0.0