-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Uplift: telemetry expirations for August #20998
Uplift: telemetry expirations for August #20998
Conversation
…#20621) * Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed. * Add ignores for performance metrics that have expired. * Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes. * Remove metrics controller from signature and remove in tests
…August (mozilla-mobile#20517) * Renew product telemetry probes expiring in august 2021 * Add placeholder for data reviews * Allow unneeded metrics to expire in August. To be re-evaluated later. * Add link to data review Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## releases_v91.0.0 #20998 +/- ##
===================================================
Coverage 36.47% 36.48%
- Complexity 1617 1618 +1
===================================================
Files 546 546
Lines 21201 21201
Branches 3172 3172
===================================================
+ Hits 7733 7735 +2
+ Misses 12596 12594 -2
Partials 872 872
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eliserichards there are no changes in this PR :). Those commits are already on 91, but not covering all expired metrics. We'll need to update those manually (can't cherry-pick commits) because some are tied to other changes we don't want in 91.
So, these commits already landed in 91 via #20626 but there are a bunch of other metrics not covered. Those have been renewed with various other commits on main and 92, but we can't just cherry-pick those as some include other changes as well. |
Maybe for the quick fix we should just add a commit here to update the search telemetry ones to the expiry dates we have on main. Basically update the following with the values from main ( And discuss separately how we want to handle this going forward for all the rest. On main we've also updated performance telemetry which would need to be uplifted to 92 and 91: (For the quick fix / dot release I would only do the three search telemetry ones though) |
b533625
to
804f08e
Compare
Uplifting these two commits to v91:Plus a new commit to update the search metrics from this PR:
browser.search
:with_ads
,ad_clicks
,in_content
These are already in v92, so there is no action needed for that.
uplift doc: https://docs.google.com/spreadsheets/d/1qIvHpcQ3BqJtlzV5T4M1MhbWVxkNiG-ToeYnWEBW4-I/edit#gid=0
Pull Request checklist
To download an APK when reviewing a PR: