Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Conversation

eliserichards
Copy link

@eliserichards eliserichards commented Aug 24, 2021

Uplifting these two commits to v91:

Plus a new commit to update the search metrics from this PR:

  • browser.search: with_ads, ad_clicks, in_content

These are already in v92, so there is no action needed for that.
uplift doc: https://docs.google.com/spreadsheets/d/1qIvHpcQ3BqJtlzV5T4M1MhbWVxkNiG-ToeYnWEBW4-I/edit#gid=0

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Elise Richards and others added 2 commits August 24, 2021 15:51
…#20621)

* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.

* Add ignores for performance metrics that have expired.

* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.

* Remove metrics controller from signature and remove in tests
…August (mozilla-mobile#20517)

* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #20998 (ec82f98) into releases_v91.0.0 (039f4ca) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ec82f98 differs from pull request most recent head 804f08e. Consider uploading reports for the commit 804f08e to get more accurate results
Impacted file tree graph

@@                 Coverage Diff                 @@
##             releases_v91.0.0   #20998   +/-   ##
===================================================
  Coverage               36.47%   36.48%           
- Complexity               1617     1618    +1     
===================================================
  Files                     546      546           
  Lines                   21201    21201           
  Branches                 3172     3172           
===================================================
+ Hits                     7733     7735    +2     
+ Misses                  12596    12594    -2     
  Partials                  872      872           
Impacted Files Coverage Δ
...c/main/java/org/mozilla/fenix/ext/AtomicInteger.kt 80.00% <0.00%> (-20.00%) ⬇️
...java/org/mozilla/fenix/perf/PerformanceInflater.kt 95.00% <0.00%> (+15.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039f4ca...804f08e. Read the comment docs.

Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eliserichards there are no changes in this PR :). Those commits are already on 91, but not covering all expired metrics. We'll need to update those manually (can't cherry-pick commits) because some are tied to other changes we don't want in 91.

@csadilek
Copy link
Contributor

So, these commits already landed in 91 via #20626 but there are a bunch of other metrics not covered. Those have been renewed with various other commits on main and 92, but we can't just cherry-pick those as some include other changes as well.

@csadilek
Copy link
Contributor

csadilek commented Aug 25, 2021

Maybe for the quick fix we should just add a commit here to update the search telemetry ones to the expiry dates we have on main. Basically update the following with the values from main (2022-07-01):
https://github.com/mozilla-mobile/fenix/blob/releases_v91.0.0/app/metrics.yaml#L4353
https://github.com/mozilla-mobile/fenix/blob/releases_v91.0.0/app/metrics.yaml#L4371
https://github.com/mozilla-mobile/fenix/blob/releases_v91.0.0/app/metrics.yaml#L4388

And discuss separately how we want to handle this going forward for all the rest. On main we've also updated performance telemetry which would need to be uplifted to 92 and 91:
#20623

(For the quick fix / dot release I would only do the three search telemetry ones though)

@eliserichards eliserichards requested review from a team as code owners August 25, 2021 15:45
@eliserichards eliserichards force-pushed the ni-telemetry-expirations-august branch from b533625 to 804f08e Compare August 25, 2021 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants