Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Uplift for 91: renew telemetry probes for August #20626

Merged

Conversation

eliserichards
Copy link

@eliserichards eliserichards commented Aug 2, 2021

Renewal issue: #20516
Doc for approvals from Product: https://docs.google.com/document/d/1NGlnTa9TPyTnd3ciUPbwujbITjkX8p8vJybXcZrrM2w/edit#

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

Elise Richards and others added 2 commits August 2, 2021 13:21
…August (mozilla-mobile#20517)

* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…#20621)

* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.

* Add ignores for performance metrics that have expired.

* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.

* Remove metrics controller from signature and remove in tests
@eliserichards eliserichards requested review from a team as code owners August 2, 2021 18:23
@eliserichards eliserichards requested review from pocmo and st3fan August 2, 2021 18:23
@eliserichards eliserichards added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Aug 2, 2021
@eliserichards eliserichards added needs:review PRs that need to be reviewed and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Aug 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (releases_v91.0.0@f168e28). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7afc1d5 differs from pull request most recent head f654832. Consider uploading reports for the commit f654832 to get more accurate results
Impacted file tree graph

@@                 Coverage Diff                 @@
##             releases_v91.0.0   #20626   +/-   ##
===================================================
  Coverage                    ?   36.47%           
  Complexity                  ?     1618           
===================================================
  Files                       ?      546           
  Lines                       ?    21201           
  Branches                    ?     3172           
===================================================
  Hits                        ?     7734           
  Misses                      ?    12594           
  Partials                    ?      873           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f168e28...f654832. Read the comment docs.

@eliserichards eliserichards added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Aug 2, 2021
@mergify mergify bot merged commit 29c3e27 into mozilla-mobile:releases_v91.0.0 Aug 2, 2021
@lobontiumira
Copy link

Hi all,
I've verified the telemetry metrics were renewed. Added the new expiration date in this doc.

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants