Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

For #20229 - Use the AC common implementation for ads/search telemetry #20230

Merged
merged 1 commit into from
Jul 14, 2021
Merged

For #20229 - Use the AC common implementation for ads/search telemetry #20230

merged 1 commit into from
Jul 14, 2021

Conversation

Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Jul 2, 2021

Everything should work exactly as before.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Mugurell Mugurell requested review from a team as code owners July 2, 2021 14:55
@Mugurell
Copy link
Contributor Author

Mugurell commented Jul 2, 2021

Request for Data Collection Renewal

  1. Provide a link to the initial Data Collection Review Request for this collection.
    Feature/#6558 Ad click attribution #10112 (comment)
  2. When will this collection now expire?
    2022-07-01
  3. Why was the initial period of collection insufficient?
    This measure will continue to help Mozilla better understand revenue trends and (potentially) aids future forecasting.

@Mugurell Mugurell added the needs:data-review PR is awaiting a data review label Jul 2, 2021
@Mugurell
Copy link
Contributor Author

Mugurell commented Jul 2, 2021

Setting do-not-land to update the metrics documentation with the telemetry renewal review first.

@travis79
Copy link
Member

Request for Data Collection Renewal

1. Provide a link to the initial Data Collection Review Request for this collection.
   [Feature/#6558 Ad click attribution #10112 (comment)](https://github.com/mozilla-mobile/fenix/pull/10112#issuecomment-617703289)

2. When will this collection now expire?
   2022-07-01

3. Why was the initial period of collection insufficient?
   This measure will continue to help Mozilla better understand revenue trends and (potentially) aids future forecasting.

Data Collection Renewal Review

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

  1. Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

Copy link
Contributor

@csadilek csadilek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-commenter
Copy link

Codecov Report

Merging #20230 (47de467) into master (b2a5723) will decrease coverage by 0.45%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20230      +/-   ##
============================================
- Coverage     36.53%   36.07%   -0.46%     
+ Complexity     1619     1564      -55     
============================================
  Files           546      538       -8     
  Lines         21196    20994     -202     
  Branches       3173     3140      -33     
============================================
- Hits           7743     7573     -170     
+ Misses        12580    12573       -7     
+ Partials        873      848      -25     
Impacted Files Coverage Δ
...src/main/java/org/mozilla/fenix/components/Core.kt 21.63% <0.00%> (ø)
...zilla/fenix/components/metrics/MetricController.kt 34.61% <0.00%> (-1.39%) ⬇️
...org/mozilla/fenix/telemetry/TelemetryMiddleware.kt 87.50% <ø> (+1.78%) ⬆️
...rg/mozilla/fenix/settings/account/AccountUiView.kt 34.14% <0.00%> (-2.44%) ⬇️
...java/org/mozilla/fenix/components/metrics/Event.kt 37.82% <0.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a5723...47de467. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review pr:do-not-land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants