This repository was archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #20229 - Use the AC common implementation for ads/search telemetry #20230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request for Data Collection Renewal
|
Setting |
Data Collection Renewal Review
Yes
Yes Resultdata-review+ |
csadilek
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Everything should work exactly as before.
Codecov Report
@@ Coverage Diff @@
## master #20230 +/- ##
============================================
- Coverage 36.53% 36.07% -0.46%
+ Complexity 1619 1564 -55
============================================
Files 546 538 -8
Lines 21196 20994 -202
Branches 3173 3140 -33
============================================
- Hits 7743 7573 -170
+ Misses 12580 12573 -7
+ Partials 873 848 -25
Continue to review full report at Codecov.
|
This was referenced Aug 25, 2021
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything should work exactly as before.
Pull Request checklist
To download an APK when reviewing a PR: