Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

[Uplift] For #21012: Update search metric expiration dates on v91 #21014

Conversation

eliserichards
Copy link

@eliserichards eliserichards commented Aug 25, 2021

For #21012

Update the search metrics from this PR:

  • browser.search: with_ads, ad_clicks, in_content

These are already in v92, so there is no action needed for that.
uplift doc: https://docs.google.com/spreadsheets/d/1qIvHpcQ3BqJtlzV5T4M1MhbWVxkNiG-ToeYnWEBW4-I/edit#gid=0

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@eliserichards eliserichards requested review from a team as code owners August 25, 2021 16:09
@eliserichards eliserichards changed the title Update search metric expiration dates [Uplift] For #21012: Update search metric expiration dates on v91 Aug 25, 2021
@eliserichards eliserichards linked an issue Aug 25, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #21014 (cb9e084) into releases_v91.0.0 (bc67504) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             releases_v91.0.0   #21014   +/-   ##
===================================================
  Coverage               36.44%   36.45%           
- Complexity               1617     1618    +1     
===================================================
  Files                     546      546           
  Lines                   21214    21214           
  Branches                 3172     3172           
===================================================
+ Hits                     7732     7734    +2     
+ Misses                  12609    12607    -2     
  Partials                  873      873           
Impacted Files Coverage Δ
...rg/mozilla/fenix/settings/account/AccountUiView.kt 34.14% <0.00%> (-2.44%) ⬇️
...java/org/mozilla/fenix/perf/PerformanceInflater.kt 95.00% <0.00%> (+15.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc67504...cb9e084. Read the comment docs.

@eliserichards eliserichards merged commit ffddd4b into mozilla-mobile:releases_v91.0.0 Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uplift expired telemetry for August
3 participants