Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

For #21012: uplift search expired telemetry for August #21013

Conversation

eliserichards
Copy link

Update the search metrics from this PR:

  • browser.search: with_ads, ad_clicks, in_content

These are already in v92, so there is no action needed for that.
uplift doc: https://docs.google.com/spreadsheets/d/1qIvHpcQ3BqJtlzV5T4M1MhbWVxkNiG-ToeYnWEBW4-I/edit#gid=0

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

MickeyMoz and others added 30 commits July 13, 2021 17:22
…ly happens once (mozilla-mobile#20383)

(cherry picked from commit 68b56ff)

Co-authored-by: Roger Yang <royang@mozilla.com>
 `removeAllTabs` will now no longer allow `UndoMiddleware` from recovering the tabs.

(cherry picked from commit 2040af6)
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
…August (mozilla-mobile#20517)

* Renew product telemetry probes expiring in august 2021

* Add placeholder for data reviews

* Allow unneeded metrics to expire in August. To be re-evaluated later.

* Add link to data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…#20621)

* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.

* Add ignores for performance metrics that have expired.

* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.

* Remove metrics controller from signature and remove in tests
@eliserichards eliserichards requested review from a team as code owners August 25, 2021 16:07
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2021

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants