Skip to content
This repository was archived by the owner on Feb 20, 2023. It is now read-only.

Feature/#6558 Ad click attribution #10112

Merged

Conversation

BranescuMihai
Copy link
Contributor

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@BranescuMihai
Copy link
Contributor Author

BranescuMihai commented Apr 22, 2020

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • These probes will be used to better model high-level trends in revenue prediction. They will also be used going forward as a standard metric (the way search volume is now) to understand the revenue impact of new prospective features.
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • This measure helps Mozilla better understand revenue trends and (potentially) aids future forecasting. It also helps us have confidence on the revenue impact of features. This does not mean Mozilla would withold a feature that reduces search revenue, it merely helps us quantify it. On the contrary: right now it is difficult to really understand the revenue impact of new features, and in the absence of evidence it is very difficult to justify some needed changes.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • No current alternative methods.
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.
  • All data is Category 2, maybe Category 3 if we consider ads as categories of webpages visited over time.
  1. How long will this data be collected?
  • Until 2020-09-01
  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@BranescuMihai BranescuMihai force-pushed the feature/#6558-add_click_attribution branch from 9479472 to ec00803 Compare April 22, 2020 10:54
@BranescuMihai BranescuMihai added the needs:data-review PR is awaiting a data review label Apr 22, 2020
These two do not contain ad servers, so we don't need to unnecessarily monitor them
The initial design replaced the onload method, which was used by others such as Bing.
With listeners it's additive, we do not replace anything.
Copy link
Contributor

@boek boek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

Instructions: Data Stewards will review a request for data collection and endorse responses to each question.

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, with metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Yes, in the Fenix settings

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Has expiry, Fenix team will monitor

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    All data is category 2.

  5. Is the data collection request for default-on or default-off?
    Default on

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    No

  7. Is the data collection covered by the existing Firefox privacy notice?
    yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Has expiry. Fenix team will monitor

  9. Does the data collection use a third-party collection tool?
    No

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants