Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Toggle Media Autoplay #255

Closed
2 tasks done
sblatz opened this issue Jan 25, 2019 · 44 comments
Closed
2 tasks done

Toggle Media Autoplay #255

sblatz opened this issue Jan 25, 2019 · 44 comments
Assignees
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Media needs:ac Needs Android Component Work needs:gecko Issues that depend on Gecko but are not GV API changes needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org

Comments

@sblatz
Copy link
Contributor

sblatz commented Jan 25, 2019

As a user, I want to be able to disable media autoplay on my browser, so I can save data and battery and have control over how I consume content.

UX mocks: https://app.abstract.com/share/cdba1651-670e-4412-8721-4d70ca025ffd?collectionLayerId=35603d5c-263c-4c70-b3fe-1ae23bd449c8&mode=design&sha=49143c0fafdf6c2d01f7c0b665c92a9fb7c0ebec

Acceptance Criteria

  • I can use a toggle in settings to allow/block media autoplay
  • When autoplay is disabled, audio and video content will not start playing unless I have initiated it.

Dependencies:

┆Issue is synchronized with this Jira Task

@cpeterso
Copy link

cpeterso commented Jan 26, 2019

GV bug to add a setting to either allow or block autoplay videos:
https://bugzilla.mozilla.org/show_bug.cgi?id=1522324

Gecko already has this functionality. Adding a GV setting should be very easy.

@bbinto
Copy link
Contributor

bbinto commented Feb 5, 2019

For TRIAGE: This should probably go into milestone 3 backlog, please size first though and indicate dependencies (planned currently for milestone 3 or 4)

@bbinto bbinto added this to the Backlog (After MVP) milestone Mar 18, 2019
@bbinto
Copy link
Contributor

bbinto commented Mar 18, 2019

As per comment, we might pull this back into a Battery saving story after MVP, however it should land for MVP as an individual feature.

@vesta0 vesta0 removed the P2 Upcoming release label Mar 28, 2019
@vesta0 vesta0 added the P1 Current sprint label Apr 4, 2019
@vesta0 vesta0 changed the title Toggle Autoplay Toggle Media Autoplay Apr 4, 2019
@vesta0 vesta0 closed this as completed May 17, 2019
@vesta0 vesta0 reopened this May 17, 2019
boek added a commit to boek/fenix that referenced this issue May 30, 2019
@vesta0 vesta0 added needs:UX-feedback Needs UX Feedback must and removed P1 Current sprint labels Jul 2, 2019
@vesta0 vesta0 added eng:qa:needed QA Needed and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Feb 4, 2020
@vesta0
Copy link
Collaborator

vesta0 commented Feb 4, 2020

@sblatz based on our conversation I am moving this issue to eng:qa:needed

@sblatz
Copy link
Contributor Author

sblatz commented Feb 6, 2020

I believe we still need to remove the feature flag here, so I don't think QA will be able to verify just yet. Making this visible is on the top of my list :)

@sblatz sblatz removed the eng:qa:needed QA Needed label Feb 6, 2020
@vesta0
Copy link
Collaborator

vesta0 commented Feb 6, 2020

Thanks for clarifying that @sblatz :)

@sblatz
Copy link
Contributor Author

sblatz commented Feb 7, 2020

@vesta0 did you end up making a follow up ticket for these other features?

@vesta0
Copy link
Collaborator

vesta0 commented Feb 7, 2020

Yes, here it is: #8017

@lobontiumira
Copy link

QA can confirm that on the latest Nightly from 2/11, the Autoplay has 2 options:

  • Video and audio blocked (Recommended) - set by default,
  • Video and audio allowed.

Verified with Google Pixel (Android 10), and OnePlus (Android 9).
However, issue #5636 is still reproducible, so I'm only going to remove the qa:needed label.

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Feb 11, 2020
@sblatz
Copy link
Contributor Author

sblatz commented Feb 18, 2020

I'm going to close this ticket and let's address #5636 as a follow up 😄

@sblatz sblatz closed this as completed Feb 18, 2020
@data-sync-user data-sync-user changed the title Toggle Media Autoplay FNX2-18068 ⁃ Toggle Media Autoplay Aug 5, 2020
@data-sync-user data-sync-user changed the title FNX2-18068 ⁃ Toggle Media Autoplay FNX3-16402 ⁃ Toggle Media Autoplay Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16402 ⁃ Toggle Media Autoplay Toggle Media Autoplay May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation Point: about 5 days eng:qa:verified QA Verified Feature:Media needs:ac Needs Android Component Work needs:gecko Issues that depend on Gecko but are not GV API changes needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org
Projects
None yet
Development

No branches or pull requests