Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug][L10N]: "Settings" string from homepage 3 dot menu needs restarting the app to be translated #25837

Closed
SoftVision-LorandJanos opened this issue Jun 30, 2022 · 1 comment · Fixed by #26243, nathanmkaya/fenix#108 or fork-house/fenix#12
Closed

[Bug][L10N]: "Settings" string from homepage 3 dot menu needs restarting the app to be translated #25837

SoftVision-LorandJanos opened this issue Jun 30, 2022 · 1 comment · Fixed by #26243, nathanmkaya/fenix#108 or fork-house/fenix#12
Assignees
@Alexandru2909
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified 🌐 L10N Localization, translation, strings, .. S3 Blocks non-critical functionality and a work around exists
Milestone
105

Comments

@SoftVision-LorandJanos
Copy link

SoftVision-LorandJanos commented Jun 30, 2022 •
edited
Loading

Steps to reproduce

  1. Open the Android "Language and Input" settings. Change the language (Ex. to Armenian).
  2. Go to Fenix and tap on the three dot menu from the homescreen.
  3. Check the content of the menu.

Expected behaviour

The options present after pressing the 3 dot menu are translated in the set language (Ex. Armenian).

Actual behaviour

The "Settings" string is not translated in the set language (Ex. Armenian).

Device name

Google Pixel 4

Android version

Android 12

Firefox release type

Firefox Beta

Firefox version

103.0.0-beta1

Device logs

No response

Additional information

https://pontoon.mozilla.org/hy-AM/firefox/browser/browser/appmenu.ftl/?search=appmenu-remote-tabs-opensettings&string=231264

Some of the other languages this issue was reproduced with:
Chinese Simplified (zh-CN)
Spanish (es-ES)
Arabic (ar)
German (de)
Portuguese (pt-PT)
Russian (ru)
French (fr)

The "Settings" string remains from the previous language every time.

Screenshot_20220630-161043

Screenshot_20220630-174024

┆Issue is synchronized with this Jira Task
@SoftVision-LorandJanos SoftVision-LorandJanos added 🐞 bug Crashes, Something isn't working, .. 🌐 L10N Localization, translation, strings, .. S3 Blocks non-critical functionality and a work around exists needs:triage Issue needs triage labels Jun 30, 2022
@SoftVision-LorandJanos SoftVision-LorandJanos changed the title [Bug][L10N]: "Settings" title is not translated in Armenian (hy-AM) [Bug][L10N]: "Settings" string is not translated in Armenian (hy-AM) Jun 30, 2022
@SoftVision-LorandJanos SoftVision-LorandJanos changed the title [Bug][L10N]: "Settings" string is not translated in Armenian (hy-AM) [Bug][L10N]: "Settings" string from homepage 3 dot menu needs restarting the app to be translated Jun 30, 2022
@Alexandru2909 Alexandru2909 self-assigned this Jul 29, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 29, 2022
For mozilla-mobile#25837 - Invalidate cached nimbusValidation values …
fee512b 
…when changing locale settings
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jul 29, 2022
@github-actions github-actions bot mentioned this issue Jul 29, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #26243 Aug 2, 2022
mergify bot pushed a commit that referenced this issue Aug 2, 2022
@mergify
For #25837 - Invalidate cached nimbusValidation values when changing …
acf9206 
…locale settings
@github-actions github-actions bot reopened this Aug 2, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 2, 2022
@github-actions github-actions bot added this to the 105 milestone Aug 2, 2022
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Aug 3, 2022
@gabrielluong
For mozilla-mobile#25837 - Invalidate cached nimbusValidation values …
a170cbd 
…when changing locale settings
@SoftVision-LorandJanos
Copy link
Author

Verified as fixed on the latest Nightly 105.0a1 (2022-08-03) build.
Device used: Google Pixel 4 (Android 12).
closing the ticket as verified.

@SoftVision-LorandJanos SoftVision-LorandJanos added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 3, 2022
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Aug 4, 2022
@gabrielluong
For mozilla-mobile#25837 - Invalidate cached nimbusValidation values …
fec8c48 
…when changing locale settings
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Aug 8, 2022
@gabrielluong
For mozilla-mobile#25837 - Invalidate cached nimbusValidation values …
3483268 
…when changing locale settings
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Aug 8, 2022
@gabrielluong
For mozilla-mobile#25837 - Invalidate cached nimbusValidation values …
94947ce 
…when changing locale settings
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Aug 9, 2022
@gabrielluong
For mozilla-mobile#25837 - Invalidate cached nimbusValidation values …
d842013 
…when changing locale settings
gabrielluong pushed a commit to gabrielluong/fenix that referenced this issue Aug 10, 2022
@gabrielluong
For mozilla-mobile#25837 - Invalidate cached nimbusValidation values …
69f5e20 
…when changing locale settings
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Aug 19, 2022
This was referenced Sep 1, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Alexandru2909 Alexandru2909

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified 🌐 L10N Localization, translation, strings, .. S3 Blocks non-critical functionality and a work around exists
Projects
None yet
Milestone
105
3 participants
@gabrielluong @Alexandru2909 @SoftVision-LorandJanos