[pull] main from mozilla-mobile:main #12

pull · 2022-07-15T00:39:33Z

See Commits and Changes for more details.

…Needed This will allow Fenix to use the refactored method name 'exitImmersiveMode' in Activity from Android Components library Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>

…i change

…dd/edit screens

This is required to avoid loading the Glean core library (provided by libxul) early on. Fenix needs to do the time measurement itself for now.

* Fix android:lineHeight Change android:lineHeight to app:lineHeight for incompatibilities at API Level <= 27 * Fix android:lineHeight (Part 2) Change android:lineHeight to app:lineHeight for fixing incompatibilities in custom_search_engine * Change android:lineHeight (Part 3) Change android:lineHeight to app:lineHeight in settings_https_only for incompatibilities at API Level <= 27 * cleanup lint-baseline.xml Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

…tialized There are three issues here that we have uncovered while investigating this bug: 1. Settings.kt has a lazy block around `enabledTotalCookieProtection` which ends up caching the first result it evaluates. 3. The `FeatureHolder` within FxNimbus caches the incorrectly evaluated value and returns this value hence forth. 4. Nimbus is not ready to return a result for an engine experiment when we need it early on in the dependency tree initialization. There are multiple systems that require engine to be initialized for them to work (e.g. Glean, Profiler, concept-fetch). In our TCP, experiment, we need to apply these engine settings during the engine initialization. So when we try and evaluate Nimbus that early on, it has not had time to initialize itself correctly or even use the engine's concept-fetch client to return the correct experiment result. This bug is made worse because of the first two caching bugs where we are always holding onto a cached value of the wrong result. Our temporary solution is to: 1. Remove the `lazy` around `Settings.enabledTotalCookieProtection`. 2. Set the `FxNimbus.api` value right after we are done initializing `FxNimbus` and `NimbusApi` so that all future queries to FxNimbus will be made against a real instance of `NimbusApi`. This is a short-term fix for the `FeatureHolder` caching bug. 3. Set a new TrackingProtectionPolicy that will evaluate Nimbus now that it is in the correct state when receive the `NimbusInterface.Observer.onUpdatesApplied`. Co-authored-by: jhugman <jhugman@users.noreply.github.com> Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>

… builds

This workaround was temporary and is not needed with the Nimbus groovy plugin updates in Android Components.

Co-authored-by: Donal Meehan <76789979+DonalMe@users.noreply.github.com>

…irst run

…er experiments are set

…creen Restore using LazyRow's "contentPadding" property to add padding to just the items while the entire section is allowed to extend to the edges of the screen and so have enough room to draw items shadows without them being clipped.

@JvmDefault

Split versioning of compose compiler. Enable Xjvm-default to allow inheriting from interfaces with '@JvmDefault' members like AbstractComposeView, NestedScrollConnection.

…vedStateRegistryOwner. ViewTreeSavedStateRegistryOwner is retrieved/set with new extension methods.

Padding value is not used for placing content.

… of ListItemTabLarge

…the CFRPopup

…ments in experimenter

…les.

…ame rule.

…ile. This automatically adds a new line at EOF when there is none.

This change should not be uplifted.

…ection-enabled feature.

…on-enabled feature.

pull bot added the ⤵️ pull label Jul 15, 2022

mozilla-l10n-automation-bot and others added 29 commits August 5, 2022 00:40

Import l10n.

926daab

For #26236: Fix breaking change from AC regarding exitImmersiveModeIf…

1488e8e

…Needed This will allow Fenix to use the refactored method name 'exitImmersiveMode' in Activity from Android Components library Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>

For #26236: Update Android Components version which introduces the ap…

624ffa7

…i change

Import l10n.

4379b06

Update Android Components version to 105.0.20220806154436.

0ed165d

Import l10n.

4f77d29

Update Android Components version to 105.0.20220807143114.

25d2233

Import l10n.

9255d35

For #26302 - Change header text height to wrap_content for autofill a…

1a2b357

…dd/edit screens

Move startup perf measurements to a background thread

06488cd

This is required to avoid loading the Glean core library (provided by libxul) early on. Fenix needs to do the time measurement itself for now.

Update Android Components version to 105.0.20220808143406.

8e3d64f

For #26289 - Remove search term tab groups metrics and setting

db01624

Import l10n.

37745eb

Update Android Components version to 105.0.20220809141528.

b3fa1b0

Fixes #26377: re-open already opened recent synced tabs

29a8c33

For #22558 - Fix private theme bug in Tabs Tray

a77375a

Add "manage account and devices" button to home menu in mozillaonline…

2a30213

… builds

Import l10n.

f356df7

Close #26198: Add debounce to account manager syncs

4204c43

Close #26041: Remove un-needed Nimbus workaround

d0c21c0

This workaround was temporary and is not needed with the Nimbus groovy plugin updates in Android Components.

Fixes #26245: refactor the WallpaperManager as several WallpaperUseCases

7295990

For #26390 Upgrade to Python3

ae21e63

use python 3.10

33406ac

Update Android Components version to 105.0.20220811143056. (#26440)

580ec1d

Co-authored-by: Donal Meehan <76789979+DonalMe@users.noreply.github.com>

Add workflow to download Nimbus early experiments

9b8ffbc

update isFirstRun to be manually set and set experiments locally on f…

1ce9950

…irst run

change name for isFirstRun to isFirstNimbusRun and move setter to aft…

b33abbb

…er experiments are set

Mugurell and others added 29 commits September 6, 2022 12:33

For #12725: Upgrade compose to 1.2.1 version.

bcfd0eb

Split versioning of compose compiler. Enable Xjvm-default to allow inheriting from interfaces with '@JvmDefault' members like AbstractComposeView, NestedScrollConnection.

For #12725: Replace removed static "set", "get" methods of ViewTreeSa…

bd35438

…vedStateRegistryOwner. ViewTreeSavedStateRegistryOwner is retrieved/set with new extension methods.

For #12725: Suppress UnusedMaterial3ScaffoldPaddingParameter warning.

d4b6bab

Padding value is not used for placing content.

For #26606 - Add backplating to Top Sites

b1369a5

Update to Android-Components 106.0.20220906143158.

509c86b

For #26797 - Add optional parameter to customize the background color…

f9380eb

… of ListItemTabLarge

Import l10n. (#26849)

7c1aa01

For #26796 - Fix PocketStoriesComposablesPreview

0ed40f2

For #26867 - Remove feature flag for first run onboarding updates

bd06b62

For #26731 - First run onboarding updates

adb7f7d

Closes #26870: remove layer behind wallpaper thumbnails

1eba805

Update to Android-Components 106.0.20220907220702.

b7317d7

For #26777 - Part 1: Rename SyncCFRPresenter to HomeCFRPresenter

86b62af

For #26777 - Part 2: Refactor the Jump Back In onboarding CFR to use …

812f073

…the CFRPopup

update initial_experiments.json based on the current first-run experi…

dedc770

…ments in experimenter

Import l10n.

316e495

For #26844: Update ktlint to 0.47.0.

231ef74

For #26844: Replace deprecated disabled_rules with ktlint_disabled_ru…

6b4d636

…les.

For #26844: Enable trailing commas rules.

0f908db

For #26844: Rename CFRPopupFullscreenLayout class to conform to filen…

9490fdf

…ame rule.

For #26844: Add ktlint baseline.

481b365

For #26844: Ensure consistent usage of a newline at the end of each f…

ca88c8c

…ile. This automatically adds a new line at EOF when there is none.

For #26869 - Enable TCP by default starting with v. 106

de38ada

This change should not be uplifted.

Closes #26858: Remove unused nimbus engine-settings total-cookie-prot…

49bef5d

…ection-enabled feature.

Closes #26858: Remove unused nimbus engine-settings tabs-prioritizati…

5358e9b

…on-enabled feature.

Closes #26858: Remove unused nimbus engine-settings tabs-prioritizati…

fd96263

…on-enabled feature.

Bug 1788643 - Enable nightly-test cron on fenix.

9ed3e8e

For #26502: Add time group and private extras in history telemetry

3081488

pull bot merged commit 3081488 into fork-house:main Sep 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] main from mozilla-mobile:main #12

[pull] main from mozilla-mobile:main #12

pull bot commented Jul 15, 2022 •

edited by github-actions bot

Loading

[pull] main from mozilla-mobile:main #12

[pull] main from mozilla-mobile:main #12

Conversation

pull bot commented Jul 15, 2022 • edited by github-actions bot Loading

pull bot commented Jul 15, 2022 •

edited by github-actions bot

Loading