Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Refactor the WallpaperManager as a WallpaperUseCase. #26245

Closed
Tracked by #26034
MatthewTighe opened this issue Jul 29, 2022 · 1 comment · Fixed by #26324, fork-house/fenix#12 or nathanmkaya/fenix#108
Closed
Tracked by #26034

Refactor the WallpaperManager as a WallpaperUseCase. #26245

MatthewTighe opened this issue Jul 29, 2022 · 1 comment · Fixed by #26324, fork-house/fenix#12 or nathanmkaya/fenix#108
Assignees
@MatthewTighe
Labels
eng:qa:verified QA Verified Feature:Wallpapers
Milestone
105

Comments

@MatthewTighe
Copy link
Contributor

MatthewTighe commented Jul 29, 2022 •
edited by data-sync-user
Loading

WallpaperUseCase seems to fit well with existing components in the app, as well as communicating more clearly what the intent is. A client of WallpaperUseCase will generally be a user-facing feature that needs to use wallpapers. This can be an opportunity to streamline the public API as well. Here are some key parts:

  • fetch wallpaper metadata
  • download a full-size wallpaper image
  • download wallpaper thumbnails
  • load the currently set wallpaper (or a wallpaper, more generally. may depend on decisions made around caching the current wallpaper in the usecase)
  • load a wallpaper thumbnail

┆Issue is synchronized with this Jira Task
@MatthewTighe MatthewTighe self-assigned this Jul 29, 2022
@MatthewTighe MatthewTighe mentioned this issue Jul 29, 2022
Closed
6 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 29, 2022
@MatthewTighe MatthewTighe mentioned this issue Jul 29, 2022
Merged
3 tasks
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 5, 2022
@MatthewTighe
Fixes mozilla-mobile#26245: refactor the WallpaperManager as several …
6103ee3 
…WallpaperUseCases
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 5, 2022
@MatthewTighe
Fixes mozilla-mobile#26245: refactor the WallpaperManager as several …
a2babf3 
…WallpaperUseCases
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 5, 2022
@github-actions github-actions bot mentioned this issue Aug 5, 2022
Merged
4 tasks
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 8, 2022
@MatthewTighe
Fixes mozilla-mobile#26245: refactor the WallpaperManager as several …
d2bfe33 
…WallpaperUseCases
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 8, 2022
@MatthewTighe
Fixes mozilla-mobile#26245: refactor the WallpaperManager as several …
282bc21 
…WallpaperUseCases
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 8, 2022
@MatthewTighe
Fixes mozilla-mobile#26245: refactor the WallpaperManager as several …
1766e32 
…WallpaperUseCases
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 9, 2022
@MatthewTighe
Fixes mozilla-mobile#26245: refactor the WallpaperManager as several …
86a58d6 
…WallpaperUseCases
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 9, 2022
@MatthewTighe
Fixes mozilla-mobile#26245: refactor the WallpaperManager as several …
e82d3ee 
…WallpaperUseCases
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 10, 2022
@MatthewTighe
Fixes mozilla-mobile#26245: refactor the WallpaperManager as several …
7d84b1f 
…WallpaperUseCases
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 10, 2022
@MatthewTighe
Fixes mozilla-mobile#26245: refactor the WallpaperManager as several …
9f3a1e1 
…WallpaperUseCases
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 10, 2022
@MatthewTighe
Fixes mozilla-mobile#26245: refactor the WallpaperManager as several …
99600c5 
…WallpaperUseCases
@MozillaNoah MozillaNoah removed the needs:triage Issue needs triage label Aug 10, 2022
@mergify mergify bot closed this as completed in #26324 Aug 11, 2022
mergify bot pushed a commit that referenced this issue Aug 11, 2022
@MatthewTighe @mergify
Fixes #26245: refactor the WallpaperManager as several WallpaperUseCases
7295990
@github-actions github-actions bot added this to the 105 milestone Aug 11, 2022
@github-actions github-actions bot reopened this Aug 11, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 11, 2022
@delia-pop
Copy link

Verified as fixed on the latest Nightly 105.0a1 from 08/15 with Google Pixel 6 (Android 12). The wallpaper feature works as expected, no issues were encountered.

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 16, 2022
This was referenced Sep 8, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MatthewTighe MatthewTighe

Labels
eng:qa:verified QA Verified Feature:Wallpapers
Projects
None yet
Milestone
105
3 participants
@MatthewTighe @MozillaNoah @delia-pop