Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix breaking change from AC regarding exitImmersiveModeIfNeeded #26236

Closed
Mugurell opened this issue Jul 29, 2022 · 2 comments · Fixed by #26238, fork-house/fenix#12 or nathanmkaya/fenix#108
Closed

Fix breaking change from AC regarding exitImmersiveModeIfNeeded #26236

Mugurell opened this issue Jul 29, 2022 · 2 comments · Fixed by #26238, fork-house/fenix#12 or nathanmkaya/fenix#108
Assignees
@indurs
Labels
eng:qa:verified QA Verified eng:tech-debt Engineering debt. Missing unit tests, etc.
Milestone
105

Comments

@Mugurell
Copy link
Contributor

Mugurell commented Jul 29, 2022 •
edited by data-sync-user
Loading

Based on the development from mozilla-mobile/android-components#12560 AC will introduce a breaking change that needs to be handled in clients.
This ticket is to address the needed changes.

┆Issue is synchronized with this Jira Task
@Mugurell Mugurell mentioned this issue Jul 29, 2022
Merged
4 tasks
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 29, 2022
@Mugurell Mugurell added eng:tech-debt Engineering debt. Missing unit tests, etc. and removed needs:triage Issue needs triage labels Jul 29, 2022
@indurs
Copy link
Contributor

indurs commented Jul 29, 2022

@Mugurell , can I work on this issue?

indurs added a commit to indurs/fenix that referenced this issue Jul 29, 2022
@indurs @Mugurell
For mozilla-mobile#26236: Fix breaking change from AC regarding exitI…
9adce2d 
…mmersiveModeIfNeeded

This will allow Fenix to use the refactored method name 'exitImmersiveMode' in Activity from Android Components library

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
@github-actions github-actions bot mentioned this issue Jul 29, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jul 29, 2022
Mugurell added a commit to indurs/fenix that referenced this issue Aug 5, 2022
@indurs @Mugurell
For mozilla-mobile#26236: Fix breaking change from AC regarding exitI…
e21da64 
…mmersiveModeIfNeeded

This will allow Fenix to use the refactored method name 'exitImmersiveMode' in Activity from Android Components library

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
Mugurell added a commit to indurs/fenix that referenced this issue Aug 5, 2022
@Mugurell
For mozilla-mobile#26236: Update Android Components version which int…
6faa3e3 
…roduces the api change
@github-actions github-actions bot mentioned this issue Aug 5, 2022
Closed
4 tasks
@mergify mergify bot closed this as completed in #26238 Aug 5, 2022
mergify bot pushed a commit that referenced this issue Aug 5, 2022
@indurs @Mugurell @mergify
For #26236: Fix breaking change from AC regarding exitImmersiveModeIf…
1488e8e 
…Needed

This will allow Fenix to use the refactored method name 'exitImmersiveMode' in Activity from Android Components library

Co-Authored-By: Mugurell <Mugurell@users.noreply.github.com>
mergify bot pushed a commit that referenced this issue Aug 5, 2022
@Mugurell @mergify
For #26236: Update Android Components version which introduces the ap…
624ffa7 
…i change
@github-actions github-actions bot added this to the 105 milestone Aug 5, 2022
@github-actions github-actions bot reopened this Aug 5, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 5, 2022
@LaurentiuApahideanSV
Copy link

I tested the issue on Firefox Nightly 105.0a1 2022-08-08 on several video sites such as https://www.youtube.com/, https://www.twitch.tv/, https://www.dailymotion.com/. I watched videos in full screen mode and pause them or wait until de video finished, in both cases the screen would lock after the screen timeout duration was met.

Devices used:

  • Google Pixel 6 (Android 13)
  • Samsung Galaxy S22 Ultra (Android 12)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 8, 2022
@Mugurell Mugurell mentioned this issue Aug 9, 2022
Closed
Closed
This was referenced Sep 6, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@indurs indurs

Labels
eng:qa:verified QA Verified eng:tech-debt Engineering debt. Missing unit tests, etc.
Projects
None yet
Milestone
105
3 participants
@Mugurell @indurs @LaurentiuApahideanSV