-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix #26362: Use app:lineHeight to support API Level <= 27 #26364
Conversation
Change android:lineHeight to app:lineHeight for incompatibilities at API Level <= 27
Change android:lineHeight to app:lineHeight for fixing incompatibilities in custom_search_engine
Change android:lineHeight to app:lineHeight in settings_https_only for incompatibilities at API Level <= 27
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
Looks great! Thank for the investigation and fix! Thank you for also organizing the work in multiple commits but probably just one |
Please check the commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! ✨
Fixes #26362
Thanks @Mugurell, I am glad to take actions to fix the issues.
This pull request changes the usages of
android:lineHeight
toapp:lineHeight
. Now the line height should be consistent among API levels.Screenshots at API Level 27
onboarding dialog
https only settings
custom search engine