Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Firefox Suggest header for library suggestion section of URL bar #25894

Closed
sarah541 opened this issue Jul 5, 2022 · 1 comment · Fixed by #25920, fork-house/fenix#12 or Smaehtin/fenix#112
Assignees
Labels
eng:qa:verified QA Verified needs:triage Issue needs triage
Milestone

Comments

@sarah541
Copy link
Contributor

sarah541 commented Jul 5, 2022

User Story

Adding the 'Firefox Suggest' branded term to URL bar suggestions pulled from library data is intended to:

Emphasize to users that library data suggestions are being generated by Firefox, and are distinct from default search suggestions

Lay the groundwork for Firefox Suggest, which is intended to further increase the value users derive from Firefox suggested results for partial query strings

Link to spec, and design mockup for reference.

Please disregard the “Sponsored” components of the design mockup, including sponsored suggestions and related settings options. Those items will be addressed in a separate issue.

Dependencies

  • List dependencies on other issues/teams etc.

Acceptance Criteria

The branded term of “Firefox Suggest” is included as a header for the section of Fenix URL bar suggestions pulled from user library data (i.e. suggested bookmarks, history, open tabs).

┆Issue is synchronized with this Jira Task

@sarah541 sarah541 added this to the 104 milestone Jul 5, 2022
@sarah541 sarah541 self-assigned this Jul 5, 2022
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 5, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Jul 6, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Jul 13, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Jul 18, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Jul 18, 2022
sarah541 added a commit to sarah541/fenix that referenced this issue Jul 18, 2022
@mergify mergify bot closed this as completed in #25920 Jul 18, 2022
@sarah541 sarah541 added the eng:qa:needed QA Needed label Jul 18, 2022
@gabrielluong gabrielluong reopened this Jul 19, 2022
@delia-pop
Copy link

delia-pop commented Jul 22, 2022

Verified as fixed on Nightly 104 from 07/22 with Google Pixel 6 (Android 12).
Also verified as fixed on Nightly 104 from 07/24. The "Firefox Suggest" header is displayed under the non-library suggestions, when data suggestions from history, bookmarks and open tabs is available.

@delia-pop delia-pop added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.