Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: Firefox will not show favicon for apple.com #26061

Closed
willfs84 opened this issue Jul 17, 2022 · 3 comments · Fixed by #26210, fork-house/fenix#12 or nathanmkaya/fenix#108
Closed

[Bug]: Firefox will not show favicon for apple.com #26061

willfs84 opened this issue Jul 17, 2022 · 3 comments · Fixed by #26210, fork-house/fenix#12 or nathanmkaya/fenix#108
Assignees
@rocketsroger
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs qa-triaged Issues triaged by qa S4 Minor significance, cosmetic issues, low or no impact to users
Milestone
105

Comments

@willfs84
Copy link

willfs84 commented Jul 17, 2022 •
edited by data-sync-user
Loading

Steps to reproduce

Go to apple.com then tap the tab view button

Expected behaviour

The apple.com tab should have the Apple favicon

Actual behaviour

Instead of showing the Apple favicon, it just shows a letter "A" in a blue box (observe screenshot)
Screenshot_20220717-151746

Device name

Google Pixel 3a XL

Android version

Android 12

Firefox release type

Firefox Nightly

Firefox version

104.0a1

Device logs

No response

Additional information

No response

┆Issue is synchronized with this Jira Task
@willfs84 willfs84 added needs:triage Issue needs triage 🐞 bug Crashes, Something isn't working, .. labels Jul 17, 2022
@SoftVision-LorandJanos
Copy link

Hi @willfs84! Thanks for your report!
While I was ale to reproduce the issue, I found a closed duplicate one (#22932) which was closed because the the root issue was already covered here: mozilla-mobile/android-components#10377.
Based on that info, I will close this issue as a duplicate.

@SoftVision-LorandJanos SoftVision-LorandJanos closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2022
@SoftVision-LorandJanos SoftVision-LorandJanos added Feature:Tabs S4 Minor significance, cosmetic issues, low or no impact to users qa-triaged Issues triaged by qa labels Jul 18, 2022
@rocketsroger rocketsroger reopened this Jul 27, 2022
@rocketsroger
Copy link
Contributor

Reopen for some updates needed to show larger icons correctly.

rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jul 27, 2022
@rocketsroger
For mozilla-mobile#26061: Make sure favicons are cropped correctly
b770ae2
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jul 27, 2022
@rocketsroger
For mozilla-mobile#26061: Make sure favicons are cropped correctly
8abb250
rocketsroger added a commit to rocketsroger/fenix that referenced this issue Jul 27, 2022
@rocketsroger
For mozilla-mobile#26061: Make sure favicons are cropped correctly
30093fe
@github-actions github-actions bot mentioned this issue Jul 27, 2022
Merged
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jul 27, 2022
@mergify mergify bot closed this as completed in #26210 Jul 27, 2022
mergify bot pushed a commit that referenced this issue Jul 27, 2022
@rocketsroger @mergify
For #26061: Make sure favicons are cropped correctly
015b79f
@github-actions github-actions bot added this to the 105 milestone Jul 27, 2022
@github-actions github-actions bot reopened this Jul 27, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Jul 27, 2022
@gabrielluong gabrielluong removed the needs:triage Issue needs triage label Jul 28, 2022
@LaurentiuApahideanSV
Copy link

I tested the issue on Firefox Nightly 105.0a1 (2022-08-02). The favicon is displayed, however the Apple logo is very small.
1659450488660
1659450426923

Devices used:

  • Samsung Galaxy S22 Ultra (Android 12)
  • Google Pixel 6 (Android 13)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 2, 2022
This was referenced Aug 31, 2022
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rocketsroger rocketsroger

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:Tabs qa-triaged Issues triaged by qa S4 Minor significance, cosmetic issues, low or no impact to users
Projects
None yet
Milestone
105
5 participants
@gabrielluong @rocketsroger @willfs84 @SoftVision-LorandJanos @LaurentiuApahideanSV