Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Deleting a bookmarks folder #3174

Closed
vesta0 opened this issue Jun 5, 2019 · 5 comments
Closed

[Telemetry] Deleting a bookmarks folder #3174

vesta0 opened this issue Jun 5, 2019 · 5 comments
Assignees
Milestone

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Jun 5, 2019

This is leftover from the original issue: #974

As a product owner, I want to track how often users delete a bookmarks folder, so that I can understand how our users interact with folder management options.

We believe this feature is useful to users, and successful when
% of users creating/deleting bookmarks or syncing bookmarks
% of users opening website via bookmark increases

What questions will you answer with this data?
-Do users delete bookmark folders and how often.

Probes:
Folder deleted

Dependencies
Glean SDK (Event ping)

Acceptance Criteria (Added by PM)
Event ping can be queried via re:dash
We are sending telemetry events for the action listed in the requirements
We have documented the telemetry
We have asked a data steward to review the telemetry

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 added P1 Current sprint Feature:Telemetry labels Jun 5, 2019
@vesta0 vesta0 added this to the Fenix 1.1 Backlog milestone Jun 5, 2019
@vesta0 vesta0 removed P1 Current sprint labels Jun 21, 2019
@sblatz sblatz self-assigned this Jun 26, 2019
@sblatz
Copy link
Contributor

sblatz commented Jun 26, 2019

This is blocked on #3693

@sblatz sblatz added 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed in progress labels Jun 26, 2019
@sblatz sblatz removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jun 27, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Jun 27, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Jun 27, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Jul 1, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Jul 1, 2019
sblatz added a commit that referenced this issue Jul 2, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sblatz sblatz added eng:qa:needed QA Needed and removed in progress labels Jul 2, 2019
@vesta0 vesta0 added the must label Jul 3, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 3, 2019

Hi, for deleting only one folder the problem is verified as fixed on the latest Fenix Build #11840608 from 2019-07-03 using the following devices:
• OnePlus6T (Android 9) (Ping 97630faf-680f-4f0f-93e8-866c7af11cc7 from the logcat)
• Samsung Galaxy S8+ (Android 8) (Ping 0decdb64-18cc-4ace-8e3a-6782cf2bc594 from the logcat)
• Samsung Galaxy S7 (Android 7.0) (Ping 9efedc65-b0dc-4d43-9567-c4260cc42115 from the logcat)

On the other hand, I've tried the following:
•Delete multiple folders
•Delete multiple folders along with a normal bookmark
As these event type pings aren't included in the Yaml I'm not sure if they are properly generated.

For deleting multiple folders the events ping looks like this:
{
"timestamp": 0,
"category": "bookmarks_management",
"name": "folder_remove"
},
{
"timestamp": 22106,
"category": "bookmarks_management",
"name": "multi_removed"
}

For deleting multiple folders along with a normal bookmark events ping looks like this:
{
"timestamp": 0,
"category": "bookmarks_management",
"name": "multi_removed"
},
{
"timestamp": 21352,
"category": "bookmarks_management",
"name": "multi_removed"
}

Please find attached and review the following documents:
OnePlus6T logcat - OnePlus.txt
OnePlus6T pings from the dashboard

Samsung Galaxy S8+ logcat - S8.txt
Samsung Galaxy S8+pings from the dashboard

Samsung Galaxy S7 logcat - S7.txt
Samsung Galaxy S7 pings from the dashboard

@sblatz & @vesta0 please be kind and confirm if this is related to only delete one folder of bookmarks and if the above mentioned 2 scenarios will follow up.
Also, please confirm if the undo will also be implemented separately.
As the multi-select feature for bookmark folders isn't working yet, I've used the workaround described in #1539

Until your confirmation, I'll leave this ticket as it is.

@sblatz
Copy link
Contributor

sblatz commented Jul 3, 2019

This seems fine to me, but @vesta0 can you confirm?

@vesta0
Copy link
Collaborator Author

vesta0 commented Jul 3, 2019

@AndiAJ @sblatz this is sufficient, we like to know how often users interact with bookmark folders and delete them, don't need to track one vs multiple at this time. Thanks!

@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 4, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jul 4, 2019

Many thanks for clarifying this topic, in this case I'll mark this as QA verified and close it.

@AndiAJ AndiAJ closed this as completed Jul 4, 2019
@colintheshots colintheshots modified the milestones: 1.1 Backlog, v1.1 Jul 23, 2019
@data-sync-user data-sync-user changed the title [Telemetry] Deleting a bookmarks folder FNX3-16834 ⁃ [Telemetry] Deleting a bookmarks folder Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16834 ⁃ [Telemetry] Deleting a bookmarks folder [Telemetry] Deleting a bookmarks folder May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants