Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #3174: Adds telemetry for bookmarks #3724

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Jun 27, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@sblatz sblatz requested a review from a team as a code owner June 27, 2019 20:07
@sblatz sblatz force-pushed the delete-bookmark-telem branch from 5e43b93 to 3b77914 Compare June 27, 2019 20:07
@sblatz
Copy link
Contributor Author

sblatz commented Jun 27, 2019

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
  • How often bookmark folders are deleted
  1. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?
  • To measure how useful these features are
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • Currently no, as these are some of the first metrics we're recording
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?

Until 04/01/2020

  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@sblatz sblatz requested a review from boek June 27, 2019 20:08
@boek boek added the needs:data-review PR is awaiting a data review label Jul 1, 2019
@boek
Copy link
Contributor

boek commented Jul 1, 2019

@sblatz Can you add documentation for the new metric to this file as well https://github.com/mozilla-mobile/fenix/blob/master/docs/metrics.md#bookmarks_management?

@sblatz sblatz force-pushed the delete-bookmark-telem branch from 3b77914 to 6e145a3 Compare July 1, 2019 18:35
@sblatz
Copy link
Contributor Author

sblatz commented Jul 1, 2019

@boek fixed!

@sblatz sblatz force-pushed the delete-bookmark-telem branch from 6e145a3 to 4034279 Compare July 1, 2019 18:36
@boek
Copy link
Contributor

boek commented Jul 1, 2019

R+

Data Review Form

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
    Yes, in metrics.yaml and metrics.md

  2. Is there a control mechanism that allows the user to turn the data collection on and off?
    Fenix allows the user to disable telemetry in settings

  3. If the request is for permanent data collection, is there someone who will monitor the data over time?
    Has expiry - 04/01/2020

  4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
    All data is category 2

  5. Is the data collection request for default-on or default-off?
    telemetry is on by default

  6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
    no

  7. Is the data collection covered by the existing Firefox privacy notice?
    yes

  8. Does there need to be a check-in in the future to determine whether to renew the data?
    Will check-in near expir

  9. Does the data collection use a third-party collection tool? If yes, escalate to legal.
    no

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs:data-review PR is awaiting a data review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants