Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] long press images with links #3611

Closed
nahuhh opened this issue Jun 23, 2019 · 9 comments
Closed

[Bug] long press images with links #3611

nahuhh opened this issue Jun 23, 2019 · 9 comments
Labels
🐞 bug Crashes, Something isn't working, .. needs:ac Needs Android Component Work P3 Some future sprint 🙅 waiting Issues that are blocked or has dependencies that are not ready

Comments

@nahuhh
Copy link

nahuhh commented Jun 23, 2019

The title probably isn't the best, but I've come across this a few times.

Steps to reproduce

  1. www.redflagdeals.com
  2. Tap and hold on the header
  3. Prompt opens

Expected behavior

Device information

  • Android device: 8.1.0 stock unrooted
  • Fenix version: 1.0.1925 (Build #11740610 🦎 68.0-20190611143747)
    ScreenshotUNITO-UNDERSCORE!20190623-060402!

www.Wal-Mart.com is another example

Scroll to the trending items, tap and hold on an image and the prompt will open.
The prompt will show the url location of the image, when it should be showing the link that tapping it leads to

EDIT: for clarity I removed reference to "open in New tab" as that is a separate issue.

┆Issue is synchronized with this Jira Task

@nahuhh nahuhh added the 🐞 bug Crashes, Something isn't working, .. label Jun 23, 2019
@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 23, 2019

This option was temporary removed for MVP in #3326 because of a bug and will be re-added later once the bug is fixed (#2312).

@bubi-luka
Copy link

The option was not removed. Please read carefully the title of this bug.

The option that @cadeyrn is refering to is for images: long click on an image and there is option "Open image in new tab". This was removed.
This bug is for links to the image (html => ). Long click opens the standard menu for links and there is "Open link in new tab". On click on this link you run into bug #2312.

This problem with images in new tab is really annoying. Any info when will the root bug solved?

@cadeyrn
Copy link
Contributor

cadeyrn commented Jun 23, 2019

Please read carefully the title of this bug.

Please don't be harsh, especially since I read carefully, you didn't read the description carefully: The issue opener said "open image in new tab", not "open link in new tab" and this was removed in #3326. Also #2312 was exactly the bug I mentioned.

But the issue opener edited the description two minutes ago. You can see in the old versions (click on the "edited" in the first comment) it was exactly as I said. Now the content is different and my comment no longer applies. But at the time of your comment my comment was correct.

@nahuhh
Copy link
Author

nahuhh commented Jun 23, 2019

Anyway, no need to fight each other. I created the confusion with my description - apologies. 🙌 don't shoot

I hope that now it's a bit more clear as to what I'm referring to?

@bubi-luka
Copy link

@cadeyrn please accept my apologies for the harsh tone, and @nahuhh for misinterpreting the issue. I was too fast writing my comment and too slow understanding what this bug report is about.

@ekager
Copy link
Contributor

ekager commented Jun 24, 2019

Looks like a dupe of #2911 which should be fixed on the AC side

@nahuhh
Copy link
Author

nahuhh commented Jul 7, 2019

I was following along #2911, which is now fixed and closed.

Looks like a different issue.

Using the same website in question as #2911 (www.cnn.com)

  • go to CNN.com and long press the image at the top of the news article
  • make note of the url that is listed in the dialog

expected behavior

The url of the article is listed

actual behavior

The url of the image is listed

@sblatz
Copy link
Contributor

sblatz commented Jul 20, 2019

Filed an ac issue.

@sblatz sblatz added needs:ac Needs Android Component Work P3 Some future sprint 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Jul 20, 2019
@nahuhh
Copy link
Author

nahuhh commented Jul 29, 2019

Confirmed fixed.
Closing

@nahuhh nahuhh closed this as completed Jul 29, 2019
@data-sync-user data-sync-user changed the title [Bug] long press images with links FNX3-17158 ⁃ [Bug] long press images with links Aug 11, 2020
@kbrosnan kbrosnan changed the title FNX3-17158 ⁃ [Bug] long press images with links [Bug] long press images with links Aug 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. needs:ac Needs Android Component Work P3 Some future sprint 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
Development

No branches or pull requests

7 participants