Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Remove open image in tab context menu #3326

Closed
kbrosnan opened this issue Jun 10, 2019 · 5 comments
Closed

Remove open image in tab context menu #3326

kbrosnan opened this issue Jun 10, 2019 · 5 comments
Assignees
Labels
eng:qa:verified QA Verified feature request 🌟 New functionality and improvements Release Blocker Blocks a Release

Comments

@kbrosnan
Copy link
Contributor

kbrosnan commented Jun 10, 2019

Why/User Benefit/User Problem

We want to prevent #2312 from happening.

What/Requirements

Long pressing on an image does not give an option to open a new tab

Acceptance Criteria (how do I know when I’m done?)

Visit several image types (PNG, JPEG, WEBP, GIF) and verify that there is not an option to open the image in a new tab.

┆Issue is synchronized with this Jira Task

@kbrosnan kbrosnan added the feature request 🌟 New functionality and improvements label Jun 10, 2019
@yoasif
Copy link
Contributor

yoasif commented Jun 10, 2019

Fennec has "View Image", which seems to work fine. Chrome also has the Open image in new tab which also works fine.

Isn't this just hiding a bug by removing a feature?

@ekager
Copy link
Contributor

ekager commented Jun 11, 2019

This will not be a long term fix, the root bug requires engine work that will not be completed by MVP so it's being deprioritized. But in the mean time, yes, we want to hide the broken feature.

@ekager ekager self-assigned this Jun 11, 2019
@ekager
Copy link
Contributor

ekager commented Jun 11, 2019

@vesta0 I got the fix for this, should we put it in the board?

@vesta0
Copy link
Collaborator

vesta0 commented Jun 11, 2019

Done :)

@vesta0 vesta0 added the Release Blocker Blocks a Release label Jun 11, 2019
@ekager ekager added the eng:qa:needed QA Needed label Jun 11, 2019
@lobontiumira lobontiumira changed the title Remove open image in tab conext menu Remove open image in tab context menu Jun 12, 2019
@lobontiumira
Copy link

Verified that long tapping on an image, the context menu triggered doesn't contain "Open image in a new tab" option. The available options are "Save" image" and "Copy image location".
Tested on the latest build 1.0.1924 (#11630619), with Samsung Galaxy Tab A 6 (Android 5.1.1), Google Pixel 3 (Android 9), and Huawei P9 Lite (Android 6).

Screenshot_20190612-074218

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 12, 2019
@data-sync-user data-sync-user changed the title Remove open image in tab context menu FNX3-16945 ⁃ Remove open image in tab context menu Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-16945 ⁃ Remove open image in tab context menu Remove open image in tab context menu May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:qa:verified QA Verified feature request 🌟 New functionality and improvements Release Blocker Blocks a Release
Projects
None yet
Development

No branches or pull requests

7 participants