Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Telemetry] Media usage #5705

Closed
vesta0 opened this issue Oct 1, 2019 · 5 comments · Fixed by #6463
Closed

[Telemetry] Media usage #5705

vesta0 opened this issue Oct 1, 2019 · 5 comments · Fixed by #6463
Assignees
Labels
E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:Media Feature:Telemetry
Milestone

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Oct 1, 2019

Description & Product Manager / Data Scientist User Story

  • As a product owner, I want to know how often the browser is used to play media, so I can prioritize media related bugs accordingly.

What probes

New probes to track the following states:

Action Item Description Works?
PLAY state Media started playing.
PAUSE state Media playback was paused.
STOP state Media playback has ended.

Acceptance Criteria

  • Event pings can be queried via re:dash
  • We are sending telemetry events for the actions listed in the requirements
  • We have documented the telemetry
  • We have asked a data steward to review the telemetry
  • NOT an AC: Data science to create dashboard or further graphs (this will be a separate issue, this issue is only about hooking up the events described and that they can be queried in re-dash)

┆Issue is synchronized with this Jira Task

@vesta0 vesta0 changed the title [Telemetry] [Telemetry] Media usage Oct 1, 2019
@vesta0 vesta0 added the E2 Estimation Point: easy, half a day to 2 days label Oct 2, 2019
@gabrielluong gabrielluong self-assigned this Nov 5, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 5, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 5, 2019
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Nov 5, 2019
@gabrielluong gabrielluong removed the eng:qa:needed QA Needed label Nov 5, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 11, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 11, 2019
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Nov 12, 2019
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Nov 13, 2019
@sblatz sblatz reopened this Nov 13, 2019
@sblatz
Copy link
Contributor

sblatz commented Nov 13, 2019

Re-opening for QA to verify

@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 19, 2019

Hi, I've just checked this on the latest Nightly Build #13230608 from 11/19 using a Google Pixel 3a XL (Android 9).

Logcat
Glean dashboard

Youtube - Ping e0f5b53e-5a3c-44bd-9044-2c5903da2fa1
✔️ Play
✔️ Pause
✔️ Stop by putting the app in background

Twitch - Ping 1a62e362-d0e8-4ed0-ad8c-b851a4aa3048
✔️ Play
✔️ Pause
✔️ Stop by closing the tab (Media Playback continues to play even if Fenix is put in background)

Vimeo - Ping 517fc32b-0bc9-4184-b4cf-1f0e605c4b5e
✔️ Play
✔️ Pause
✔️ Stop by leaving the media playback to end

❓ Play/Pause from the open tabs section - Ping 5ef667d2-b9ec-47da-8239-d4876c925295

Aren't correctly generated (seem to be inverted, when pressing pause a "media_play" "tab" category ping is generated and vice versa) the correlation with the "media_state" category is done properly.

E.g.
1. Tap pause from the Open tabs
"events": [
{
"category": "tab",
"name": "media_play",
"timestamp": 0
},
{
"category": "media_state",
"name": "pause",
"timestamp": 135
}
]

2. Tap play from the Open tabs
"events": [
{
"category": "tab",
"name": "media_pause",
"timestamp": 0
},
{
"category": "media_state",
"name": "play",
"timestamp": 127
}
]

@vesta0 & @gabrielluong - Not sure if the Media usage from the Open tabs was also covered or should have been covered.
Please and let me know how should we proceed. ☺️

@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Nov 27, 2019
@AndiAJ
Copy link
Collaborator

AndiAJ commented Nov 27, 2019

I'll remove the QA needed label until further notice.

@gabrielluong
Copy link
Member

Hi @AndiAJ, only media_state pings were covered in this fixed. Seeing that tab.media_play and tab.media_pause are pinged incorrectly, can you open a new issue on that and we will look into that.

@AndiAJ
Copy link
Collaborator

AndiAJ commented Dec 6, 2019

Hi @gabrielluong , thanks for clarifying this! ☺️
I've re-tested this on Fenix Nightly Build #13391806 from 12/5 and it works properly.

Youtube - Ping 6e8cf0ee-4a3c-4a23-bb8e-5c2e09ae5023
✔️ Play
✔️ Pause
✔️ Stop by putting the app in background

Twitch - Ping 1c6ed89b-9b1c-42ef-9cda-4b6bf553178f
✔️ Play
✔️ Pause
✔️ Stop by closing the tab (Media Playback continues to play even if Fenix is put in background)

Vimeo - Ping 34d7e3e2-2ffd-457a-a132-8a9c4f8c6d3f
✔️ Play
✔️ Pause
✔️ Stop by leaving the media playback to end

Logcat
Glean Dashboard

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2 Estimation Point: easy, half a day to 2 days eng:qa:verified QA Verified Feature:Media Feature:Telemetry
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants