This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #5705 - Adds telemetry for media state #6463
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
Codecov Report
@@ Coverage Diff @@
## master #6463 +/- ##
============================================
- Coverage 16.8% 16.77% -0.03%
Complexity 349 349
============================================
Files 271 271
Lines 10635 10650 +15
Branches 1478 1483 +5
============================================
Hits 1787 1787
- Misses 8701 8716 +15
Partials 147 147
Continue to review full report at Codecov.
|
boek
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
yes, in metrics.yaml and the generated metrics.md
- Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.
Controlled by Fenix data controls
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2, media playback interaction
- Is the data collection request for default-on or default-off?
Default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Has expiry
- Does the data collection use a third-party collection tool?
No
boek
added
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
and removed
needs:data-review
PR is awaiting a data review
labels
Nov 12, 2019
vespertineSiren
pushed a commit
to vespertineSiren/fenix
that referenced
this pull request
Nov 18, 2019
3 tasks
3 tasks
6 tasks
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5705. We pick up the
Fact
s emitted from theMedia
component that are documented in https://github.com/mozilla-mobile/android-components/tree/master/components/feature/media#facts.Pull Request checklist
After merge
To download an APK when reviewing a PR: