Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #8125: Add default top site telemetry #10752

Merged
merged 1 commit into from
May 22, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented May 18, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz added the needs:data-review PR is awaiting a data review label May 18, 2020
@sblatz
Copy link
Contributor Author

sblatz commented May 18, 2020

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?
    -How often do users interact with default top sites?

  2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

  • We want to know if users find default top sites useful.
  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • N/A (These are baseline metrics)
  1. Can current instrumentation answer these questions?
  • Currently there are no events to track this event, though we do track other top site interactions, so we'd like data on this one as well.
  1. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.
  • All data is Category 2.
  1. How long will this data be collected?

Until 09/01/2020

  1. What populations will you measure?
  • All release, beta, and nightly users with telemetry enabled.
  1. Please provide a general description of how you will analyze this data.
  • Glean / Amplitude
  1. Where do you intend to share the results of your analysis?
  • Only on Glean, Amplitude and with mobile teams.

@sblatz sblatz requested a review from boek May 18, 2020 19:44
@sblatz sblatz force-pushed the default-top-sites-telem branch 2 times, most recently from 3cff1ae to fdb5c4f Compare May 19, 2020 20:59
@sblatz sblatz requested a review from liuche May 19, 2020 21:40
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Review Form (to be filled by Data Stewards)

  1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, documented in metrics.md

  1. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, handled by Fenix data controls

  1. If the request is for permanent data collection, is there someone who will monitor the data over time?

Expiry in 6mo

  1. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2, clicking on suggested content, interaction data

  1. Is the data collection request for default-on or default-off?

default on

  1. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

  1. Is the data collection covered by the existing Firefox privacy notice?

Yes

  1. Does there need to be a check-in in the future to determine whether to renew the data?

No, has expiry

  1. Does the data collection use a third-party collection tool?
    no

app/metrics.yaml Outdated
bugs:
- https://github.com/mozilla-mobile/fenix/issues/8125
data_reviews:
- https://github.com/mozilla-mobile/fenix/pull/TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@liuche
Copy link
Contributor

liuche commented May 20, 2020

One last thing @sblatz - I was checking to make sure that everything Vesta asked for in the ping was handled.

When going over the top sites count, came across this comment, but I don't think the documentation handles this properly.

Can you update the docs for this ping to make sure that they make it clear that "0" is not a possible value for top sites count? (or verify what acceptable values of that can be)

@liuche liuche removed the needs:data-review PR is awaiting a data review label May 20, 2020
@sblatz sblatz force-pushed the default-top-sites-telem branch 4 times, most recently from 7220b32 to 3ae63c0 Compare May 22, 2020 18:35
@sblatz sblatz force-pushed the default-top-sites-telem branch from 3ae63c0 to 02880b5 Compare May 22, 2020 19:44
@sblatz sblatz merged commit 7067e5c into mozilla-mobile:master May 22, 2020
@liuche liuche mentioned this pull request Jun 10, 2020
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants