-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #8125: Add default top site telemetry #10752
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Until 09/01/2020
|
3cff1ae
to
fdb5c4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, documented in metrics.md
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, handled by Fenix data controls
- If the request is for permanent data collection, is there someone who will monitor the data over time?
Expiry in 6mo
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2, clicking on suggested content, interaction data
- Is the data collection request for default-on or default-off?
default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does there need to be a check-in in the future to determine whether to renew the data?
No, has expiry
- Does the data collection use a third-party collection tool?
no
app/metrics.yaml
Outdated
bugs: | ||
- https://github.com/mozilla-mobile/fenix/issues/8125 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/fenix/pull/TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
One last thing @sblatz - I was checking to make sure that everything Vesta asked for in the ping was handled. When going over the top sites count, came across this comment, but I don't think the documentation handles this properly. Can you update the docs for this ping to make sure that they make it clear that "0" is not a possible value for top sites count? (or verify what acceptable values of that can be) |
7220b32
to
3ae63c0
Compare
3ae63c0
to
02880b5
Compare
Pull Request checklist
After merge
To download an APK when reviewing a PR: