-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #8125 - Send top sites count with metrics ping #9556
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9556 +/- ##
============================================
- Coverage 19.41% 19.41% -0.01%
Complexity 519 519
============================================
Files 335 335
Lines 13451 13472 +21
Branches 1791 1793 +2
============================================
+ Hits 2611 2615 +4
- Misses 10616 10633 +17
Partials 224 224
Continue to review full report at Codecov.
|
da1e6e7
to
9240ccd
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Does this user have any top sites and how many do they have?
We've seen a correlation between startup time and the number of top sites in local testing and knowing quantities will better inform both technical and UX-based solutions.
Local testing for performance, but knowing how many top sites real users have will help inform the teams for performance investigations.
No, top sites are a new feature.
Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
|
9240ccd
to
1205cdb
Compare
1205cdb
to
79eaf41
Compare
cc @boek this is ready for review + data review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, metrics.yaml and metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, under data controls -
If the request is for permanent data collection, is there someone who will monitor the data over time?
Has expiry -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2 -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
Yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry -
Does the data collection use a third-party collection tool?
no
@@ -689,6 +678,8 @@ class HomeFragment : Fragment() { | |||
private fun subscribeToTopSites(): Observer<List<TopSite>> { | |||
return Observer<List<TopSite>> { topSites -> | |||
requireComponents.core.topSiteStorage.cachedTopSites = topSites | |||
context?.settings()?.preferences?.edit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just use the topSitesSize
intPreference
that you added in Settings.kt
here?
Pull Request checklist
After merge
To download an APK when reviewing a PR: