-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #15366: Add recently closed tabs metrics. #16739
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16739 +/- ##
============================================
- Coverage 30.14% 30.10% -0.04%
Complexity 1206 1206
============================================
Files 454 454
Lines 18556 18597 +41
Branches 2560 2565 +5
============================================
+ Hits 5594 5599 +5
- Misses 12520 12556 +36
Partials 442 442
Continue to review full report at Codecov.
|
109fc09
to
a323f00
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection. 1) What questions will you answer with this data? 2) Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? 3) What alternative methods did you consider to answer these questions? Why were they not sufficient? 4) Can current instrumentation answer these questions? 5) List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki. Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
6) Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way. 7) How long will this data be collected? Choose one of the following: 8) What populations will you measure? 9) If this data collection is default on, what is the opt-out mechanism for users? 10) Please provide a general description of how you will analyze this data. 11) Where do you intend to share the results of your analysis? 12) Is there a third-party tool (i.e. not Telemetry) that you are proposing to use for this data collection? |
dce7ef9
to
1a6ea67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
-
Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, metrics.yaml and metrics.md -
Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, Fenix data collection settings. -
If the request is for permanent data collection, is there someone who will monitor the data over time?
No, Fenix team will monitor -
Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2 -
Is the data collection request for default-on or default-off?
Default on -
Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No -
Is the data collection covered by the existing Firefox privacy notice?
Yes -
Does there need to be a check-in in the future to determine whether to renew the data?
Has expiry -
Does the data collection use a third-party collection tool?
No
Pull Request checklist
To download an APK when reviewing a PR: