-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #19915: Add telemetry for the toolbar Home screen button. #19936
Conversation
1a91d20
to
ea8c72c
Compare
Codecov Report
@@ Coverage Diff @@
## master #19936 +/- ##
============================================
- Coverage 36.79% 36.78% -0.01%
+ Complexity 1622 1620 -2
============================================
Files 535 535
Lines 20961 20961
Branches 3117 3118 +1
============================================
- Hits 7712 7710 -2
- Misses 12356 12358 +2
Partials 893 893
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine. @mcarare I am wondering if we also filed a DS request to confirm we want this as an event ping, which I think makes sense here, but I guess we should be sure by checking with DS. You may need to ping #data-help on slack.
Request for data collection review
|
data-review+, thanks!
Yes, in the probe definition files and the Glean dictionary.
Yes, the Firefox telemetry opt-out.
n/a
Cat 2, interaction data
Default-on.
No
Yes
No |
Pull Request checklist
-> No visual changes.
-> No user-facing features.
To download an APK when reviewing a PR: