Closes #27292: renew telemetry expiring in 108 and 109 #27295

MatthewTighe · 2022-10-05T23:03:15Z

Pull Request checklist

Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

Click on Checks at the top of the PR page.
Click on the firefoxci-taskcluster group on the left to expand all tasks.
Click on the build-debug task.
Click on View task in Taskcluster in the new DETAILS section.
The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #27292

MatthewTighe · 2022-10-05T23:22:13Z

Request for Data Collection Renewal

Renew for 1 year

Total: 27
———

events.browser_menu_action

Provide a link to the initial Data Collection Review Request for this collection.
- Adds Metrics for Crash reporter and browser menu items #1214 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- This is a primary UI interaction

———
events.whats_new_tapped

Provide a link to the initial Data Collection Review Request for this collection.
- For #5021: Adds metric for what's new button #5090
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- MR '22 feature

———
events.browser_toolbar_home_tapped

Provide a link to the initial Data Collection Review Request for this collection.
- For #19915: Add telemetry for the toolbar Home screen button. #19936
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- This is a primary UI interaction

———
error_page.visited_error

Provide a link to the initial Data Collection Review Request for this collection.
- For #1242: Adds telemetry for error pages #2491 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- This is a primary UI interaction

———
recently_closed_tabs.opened

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.closed

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.show_full_history

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.open_tab

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.delete_tab

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.menu_close

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.menu_share

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.menu_delete

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.menu_open_in_normal_tab

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.menu_open_in_private_tab

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.enter_multiselect

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
recently_closed_tabs.exit_multiselect

Provide a link to the initial Data Collection Review Request for this collection.
- For #21009 - New Recently closed tabs telemetry #22588 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
app_theme.dark_theme_selected

Provide a link to the initial Data Collection Review Request for this collection.
- For #7289: Adds telemetry for selecting dark theme #7968
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- MR '22 feature

———
android_autofill.supported

Provide a link to the initial Data Collection Review Request for this collection.
- Add telemetry for Android Autofill feature. #20547 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
android_autofill.enabled

Provide a link to the initial Data Collection Review Request for this collection.
- Add telemetry for Android Autofill feature. #20547 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
android_autofill.request_matching_logins

Provide a link to the initial Data Collection Review Request for this collection.
- Add telemetry for Android Autofill feature. #20547 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
android_autofill.request_no_matching_logins

Provide a link to the initial Data Collection Review Request for this collection.
- Add telemetry for Android Autofill feature. #20547 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
android_autofill.search_displayed

Provide a link to the initial Data Collection Review Request for this collection.
- Add telemetry for Android Autofill feature. #20547 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
android_autofill.search_item_selected

Provide a link to the initial Data Collection Review Request for this collection.
- Add telemetry for Android Autofill feature. #20547 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
android_autofill.unlock_cancelled

Provide a link to the initial Data Collection Review Request for this collection.
- Add telemetry for Android Autofill feature. #20547 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
android_autofill.unlock_successful

Provide a link to the initial Data Collection Review Request for this collection.
- Add telemetry for Android Autofill feature. #20547 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
android_autofill.confirm_cancelled

Provide a link to the initial Data Collection Review Request for this collection.
- Add telemetry for Android Autofill feature. #20547 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———
android_autofill.confirm_successful

Provide a link to the initial Data Collection Review Request for this collection.
- Add telemetry for Android Autofill feature. #20547 (comment)
When will this collection now expire?
- 122
Why was the initial period of collection insufficient?
- Looking at followup work for iterating on this feature

———

gabrielluong · 2022-10-07T05:00:40Z

Just a reminder that the TBD needs to be replaced in the data form 🫣

MatthewTighe · 2022-10-07T16:30:50Z

Just a reminder that the TBD needs to be replaced in the data form 🫣

Yeah, I'm working on a script to do it for me 🙂

MatthewTighe · 2022-10-11T23:13:47Z

@rocketsroger this should be ready for review now

rocketsroger · 2022-10-12T02:35:10Z

Request for Data Collection Renewal

Renew for 1 year

Total: 27 ———

events.browser_menu_action

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Adds Metrics for Crash reporter and browser menu items #1214 (comment)](https://github.com/mozilla-mobile/fenix/pull/1214#issue-264756708)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * This is a primary UI interaction

——— events.whats_new_tapped

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #5021: Adds metric for what's new button #5090](https://github.com/mozilla-mobile/fenix/pull/5090)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * MR '22 feature

——— events.browser_toolbar_home_tapped

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #19915: Add telemetry for the toolbar Home screen button. #19936](https://github.com/mozilla-mobile/fenix/pull/19936)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * This is a primary UI interaction

——— error_page.visited_error

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #1242: Adds telemetry for error pages #2491 (comment)](https://github.com/mozilla-mobile/fenix/pull/2491#issuecomment-492414486)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * This is a primary UI interaction

——— recently_closed_tabs.opened

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.closed

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.show_full_history

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.open_tab

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.delete_tab

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.menu_close

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.menu_share

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.menu_delete

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.menu_open_in_normal_tab

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.menu_open_in_private_tab

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.enter_multiselect

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— recently_closed_tabs.exit_multiselect

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #21009 - New Recently closed tabs telemetry #22588 (comment)](https://github.com/mozilla-mobile/fenix/pull/22588#issuecomment-1024352995)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— app_theme.dark_theme_selected

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [For #7289: Adds telemetry for selecting dark theme #7968](https://github.com/mozilla-mobile/fenix/pull/7968)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * MR '22 feature

——— android_autofill.supported

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add telemetry for Android Autofill feature. #20547 (comment)](https://github.com/mozilla-mobile/fenix/pull/20547#issuecomment-889051503)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— android_autofill.enabled

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add telemetry for Android Autofill feature. #20547 (comment)](https://github.com/mozilla-mobile/fenix/pull/20547#issuecomment-889051503)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— android_autofill.request_matching_logins

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add telemetry for Android Autofill feature. #20547 (comment)](https://github.com/mozilla-mobile/fenix/pull/20547#issuecomment-889051503)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— android_autofill.request_no_matching_logins

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add telemetry for Android Autofill feature. #20547 (comment)](https://github.com/mozilla-mobile/fenix/pull/20547#issuecomment-889051503)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— android_autofill.search_displayed

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add telemetry for Android Autofill feature. #20547 (comment)](https://github.com/mozilla-mobile/fenix/pull/20547#issuecomment-889051503)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— android_autofill.search_item_selected

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add telemetry for Android Autofill feature. #20547 (comment)](https://github.com/mozilla-mobile/fenix/pull/20547#issuecomment-889051503)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— android_autofill.unlock_cancelled

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add telemetry for Android Autofill feature. #20547 (comment)](https://github.com/mozilla-mobile/fenix/pull/20547#issuecomment-889051503)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— android_autofill.unlock_successful

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add telemetry for Android Autofill feature. #20547 (comment)](https://github.com/mozilla-mobile/fenix/pull/20547#issuecomment-889051503)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— android_autofill.confirm_cancelled

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add telemetry for Android Autofill feature. #20547 (comment)](https://github.com/mozilla-mobile/fenix/pull/20547#issuecomment-889051503)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

——— android_autofill.confirm_successful

1. Provide a link to the initial Data Collection Review Request for this collection.
   
   * [Add telemetry for Android Autofill feature. #20547 (comment)](https://github.com/mozilla-mobile/fenix/pull/20547#issuecomment-889051503)

2. When will this collection now expire?
   
   * 122

3. Why was the initial period of collection insufficient?
   
   * Looking at followup work for iterating on this feature

———

Data Collection Renewal Review

Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes

Is the data collection covered by the existing Firefox Privacy Notice?

Yes

Result

data-review+

MatthewTighe requested review from a team as code owners October 5, 2022 23:03

Amejia481 added the needs:data-review PR is awaiting a data review label Oct 6, 2022

Amejia481 requested a review from rocketsroger October 6, 2022 15:10

MatthewTighe force-pushed the 109-telemetry branch from ecb4d7f to 92e7aeb Compare October 11, 2022 23:12

rocketsroger removed the needs:data-review PR is awaiting a data review label Oct 12, 2022

rocketsroger approved these changes Oct 12, 2022

View reviewed changes

rocketsroger added the pr:approved PR that has been approved label Oct 12, 2022

MatthewTighe added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Oct 12, 2022

MatthewTighe closed this Oct 12, 2022

MatthewTighe reopened this Oct 12, 2022

Closes mozilla-mobile#27292: renew telemetry expiring in 108 and 109

df2b41c

MatthewTighe force-pushed the 109-telemetry branch from 92e7aeb to df2b41c Compare October 12, 2022 18:21

mergify bot merged commit 846e609 into mozilla-mobile:main Oct 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Closes #27292: renew telemetry expiring in 108 and 109 #27295

Closes #27292: renew telemetry expiring in 108 and 109 #27295

MatthewTighe commented Oct 5, 2022 •

edited by github-actions bot

Loading

MatthewTighe commented Oct 5, 2022 •

edited

Loading

gabrielluong commented Oct 7, 2022

MatthewTighe commented Oct 7, 2022

MatthewTighe commented Oct 11, 2022

rocketsroger commented Oct 12, 2022

Request for Data Collection Renewal

Renew for 1 year

Closes #27292: renew telemetry expiring in 108 and 109 #27295

Closes #27292: renew telemetry expiring in 108 and 109 #27295

Conversation

MatthewTighe commented Oct 5, 2022 • edited by github-actions bot Loading

Pull Request checklist

QA

To download an APK when reviewing a PR (after all CI tasks finished running):

GitHub Automation

MatthewTighe commented Oct 5, 2022 • edited Loading

Request for Data Collection Renewal

Renew for 1 year

gabrielluong commented Oct 7, 2022

MatthewTighe commented Oct 7, 2022

MatthewTighe commented Oct 11, 2022

rocketsroger commented Oct 12, 2022

Request for Data Collection Renewal

Renew for 1 year

Data Collection Renewal Review

Result

MatthewTighe commented Oct 5, 2022 •

edited by github-actions bot

Loading

MatthewTighe commented Oct 5, 2022 •

edited

Loading