Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #22226 - Open grouped history entries the same as individual ones #22244

Merged
merged 1 commit into from
Nov 2, 2021
Merged

For #22226 - Open grouped history entries the same as individual ones #22244

merged 1 commit into from
Nov 2, 2021

Conversation

Mugurell
Copy link
Contributor

@Mugurell Mugurell commented Nov 1, 2021

OpeningHistoryGroups.mov

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@Mugurell Mugurell requested review from a team as code owners November 1, 2021 14:51
@gabrielluong gabrielluong added the pr:approved PR that has been approved label Nov 1, 2021
@Mugurell Mugurell added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Nov 2, 2021
@mergify mergify bot merged commit 9cce30b into mozilla-mobile:main Nov 2, 2021
@Mugurell Mugurell deleted the historyFolderCrash branch November 2, 2021 08:04
@csadilek
Copy link
Contributor

csadilek commented Nov 5, 2021

@Mugurell I think we should consider uplifting this to 95 as it's a crash fix and just missed the cut-off. However, it exposed the intermittent UI test failure in #22256 so don't want to uplift now and make the 95 branch flaky until we have that test under control as well.

@csadilek
Copy link
Contributor

csadilek commented Nov 9, 2021

ok, based on #22339 the test doesn't appear to be an issue anymore. let's uplift this crash fix.

@csadilek
Copy link
Contributor

csadilek commented Nov 9, 2021

@Mergifyio backport releases_v95.0.0

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

backport releases_v95.0.0

✅ Backports have been created

@Mugurell Mugurell restored the historyFolderCrash branch June 14, 2022 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants