-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #5094: Adds telemetry for suggestion toggles #5704
For #5094: Adds telemetry for suggestion toggles #5704
Conversation
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Until 03/01/2020
|
Codecov Report
@@ Coverage Diff @@
## master #5704 +/- ##
=========================================
Coverage ? 14.42%
Complexity ? 323
=========================================
Files ? 256
Lines ? 10534
Branches ? 1536
=========================================
Hits ? 1520
Misses ? 8891
Partials ? 123
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, in metrics.md
generated by Glean from metrics.yaml
- Is there a control mechanism that allows the user to turn the data collection on and off?
Yes, from Fenix data settings
- If the request is for permanent data collection, is there someone who will monitor the data over time?
No, expires in 3/2020
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2
- Is the data collection request for default-on or default-off?
Default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No, collecting preferences states
- Is the data collection covered by the existing Firefox privacy notice?
Yes
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
Has expiration
- Does the data collection use a third-party collection tool? If yes, escalate to legal.
No
app/metrics.yaml
Outdated
data_reviews: | ||
- https://github.com/mozilla-mobile/fenix/pull/1896 | ||
- https://github.com/mozilla-mobile/fenix/pull/TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Is the process that you update this after you get data-review, or when you open the PR?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I do the PR I usually swap the "TODO" my bad for missing this one 😅
648fdd7
to
3338696
Compare
Pull Request checklist
After merge
To download an APK when reviewing a PR: