Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-11279 - [Toolbar Redesign] Selecting any search suggestion doesn't open google with new tab with custom URL #24611

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Bugfix FXIOS-11279 - [Toolbar Redesign] Selecting any search suggestion doesn't open google with new tab with custom URL #24611

merged 5 commits into from
Feb 7, 2025

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Feb 6, 2025 •
edited
Loading

📜 Tickets

Jira ticket
Github issue

💡 Description

  • To avoid a synchronization problem where the suggestion was tapped and instead of being searched for, the overlay mode would get canceled, not performing the search based on the tapped suggestion, this PR checks for the toolbar refactor if the search term is nil, meaning that the search is not tapped nor highlighted, so it's okay to leave overlay mode.

Video

video.MP4

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@PARAIPAN9 PARAIPAN9 added the weekly-release Tagging backports for rapid release label Feb 6, 2025
@PARAIPAN9 PARAIPAN9 requested a review from a team as a code owner February 6, 2025 19:23
@PARAIPAN9 PARAIPAN9 requested a review from dataports February 6, 2025 19:23
@PARAIPAN9
Copy link
Collaborator Author

@Mergifyio backport release/v135

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 6, 2025 •
edited
Loading

backport release/v135

✅ Backports have been created

dataports
dataports reviewed Feb 6, 2025
View reviewed changes
firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift Outdated
@@ -4252,10 +4252,23 @@ extension BrowserViewController: KeyboardHelperDelegate {

private func finishEditionMode() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rename this function to cancelEditingMode() to align with naming of other methods.

dataports
dataports approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@dataports dataports left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one small suggestion

@PARAIPAN9 PARAIPAN9 merged commit aa856cf into main Feb 7, 2025
10 checks passed
@PARAIPAN9 PARAIPAN9 deleted the sparaipan/fxios-11279-Selecting-any-search-suggestion-does-not-open-google-with-new-tab-with-custom-URL branch February 7, 2025 12:09
mergify bot pushed a commit that referenced this pull request Feb 7, 2025
@PARAIPAN9 @mergify
Bugfix FXIOS-11279 - [Toolbar Redesign] Selecting any search suggesti…
344fa34 
…on doesn't open google with new tab with custom URL (#24611)

* Check for nil of search term before exiting overlay mode

* Revert change

* Rename method

* Remove final

(cherry picked from commit aa856cf)
@mergify mergify bot mentioned this pull request Feb 7, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataports dataports dataports approved these changes

Assignees
No one assigned
Labels
weekly-release Tagging backports for rapid release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PARAIPAN9 @dataports