Closes #614: Process Custom Tab intent again if activity is recreated #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocmo
reviewed
Aug 2, 2019
| override fun onCreate(savedInstanceState: Bundle?) { | ||
|
|
||
| // If a Custom Tab is restored by the OS after low memory, we need to process the intent again. | ||
| components.utils.intentProcessor.process(intent) |
There was a problem hiding this comment.
I fail to understand why this activity would be recreated with the custom tab intent instead of the intent this activity was created with 🤔
|
Closing since this temporary fix doesn't work any more after breaking up the browser fragment and activities and/or multiple intent processors. Will continue the investigation in the ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mozilla-mobile/android-components#3773 (comment) for a detailed explanation for this change.
Pull Request checklist
Before merging checklist