Remove seemingly-unnecessary urldecoding #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhearsum
requested review from
jcristau,
gbrownmozilla and
gabrielBusta
as code owners
jcristau
reviewed
Jul 5, 2023
src/auslib/web/public/client.py
Outdated
| @@ -110,7 +104,7 @@ def getQueryFromURL(url): | |||
| if "systemCapabilities" in query: | |||
| query.update(getSystemCapabilities(url["systemCapabilities"])) | |||
| del query["systemCapabilities"] | |||
| query["osVersion"] = unquote(query["osVersion"]) | |||
| query["osVersion"] = query["osVersion"] | |||
I added this a Very Long Time Ago in mozilla-releng@adb45b6. I don't see anything in there that suggests it was needed, nor do any tests fail if it is removed. There's no data in this field that _should_ be urlencoded, and even if there was, decoding is already handled by Flask/Werkzeug...so we should be able to safely remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added this a Very Long Time Ago in adb45b6. I don't see anything in there nor the bug it references that suggests it was needed, nor do any tests fail if it is removed. There's no data in this field that should be urlencoded, and even if there was, decoding is already handled by Flask/Werkzeug...so we should be able to safely remove this.