Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Ensure autopush_rs port binds to 0.0.0.0 #1113

Closed
pjenvey opened this issue Jan 29, 2018 · 0 comments · Fixed by #1137
Closed

Ensure autopush_rs port binds to 0.0.0.0 #1113

pjenvey opened this issue Jan 29, 2018 · 0 comments · Fixed by #1137
Assignees
@pjenvey
Labels
bug
Milestone
2018Q1-1.1 Rust c...

Comments

@pjenvey
Copy link
Member

pjenvey commented Jan 29, 2018

Currently it binds ports according to AutopushConfig's hostname/router_hostname, which we don't actually use for binding ports in Python via twisted.
@pjenvey pjenvey added the bug label Jan 29, 2018
@pjenvey pjenvey self-assigned this Jan 29, 2018
@pjenvey pjenvey mentioned this issue Jan 29, 2018
Merged
@pjenvey pjenvey added the ready label Jan 31, 2018
@pjenvey pjenvey added in progress and removed ready labels Feb 14, 2018
pjenvey added a commit that referenced this issue Feb 15, 2018
@pjenvey
fix: bind autopush_rs to all interfaces to match python
b49ecfa 
cleanup instance id or hostname used for logging/metrics and duplicate
some of that setup in rust (which'll eventually need it anyway)

and some mypy fixes

Closes #1113
pjenvey added a commit that referenced this issue Feb 16, 2018
@pjenvey
fix: bind autopush_rs to all interfaces to match python
b53a005 
cleanup instance id or hostname used for logging/metrics and duplicate
some of that setup in rust (which'll eventually need it anyway)

some mypy fixes, update to cadence release

Closes #1113
@pjenvey pjenvey mentioned this issue Feb 16, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug
Projects
None yet
Milestone
2018Q1-1.1 Rust connection nodes work...
Development

Successfully merging a pull request may close this issue.

fix: bind autopush_rs to all interfaces to match python mozilla-services/autopush
2 participants
@pjenvey @bbangert