Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Upgrade GCM/ADM bridges to use twisted async http #1291

Closed
jrconlin opened this issue Aug 28, 2018 · 4 comments
Closed

Upgrade GCM/ADM bridges to use twisted async http #1291

jrconlin opened this issue Aug 28, 2018 · 4 comments
Assignees
@jrconlin
Labels
in progress p2

Comments

@jrconlin
Copy link
Member

jrconlin commented Aug 28, 2018 •
edited
Loading

Older code is using the old thread post model. We should standardize from requests.post where possible.
@jrconlin
Copy link
Member Author

see; https://github.com/mozilla-services/autopush/blob/master/autopush/router/webpush.py#L191

@jrconlin jrconlin self-assigned this Aug 29, 2018
jrconlin added a commit that referenced this issue Sep 29, 2018
@jrconlin
WIP: make gcm calls use async callbacks
c924423 
Closes #1291
jrconlin added a commit that referenced this issue Oct 1, 2018
@jrconlin
feat: make gcm calls use async callbacks
eb8c0d1 
Closes #1291
jrconlin added a commit that referenced this issue Oct 1, 2018
@jrconlin
feat: make gcm calls use async callbacks
00432dc 
Closes #1291
@jrconlin jrconlin mentioned this issue Oct 1, 2018
Merged
@jrconlin jrconlin removed the ready label Oct 1, 2018
jrconlin added a commit that referenced this issue Oct 2, 2018
@jrconlin
feat: make gcm calls use async callbacks
8ea2304 
Closes #1291
jrconlin added a commit that referenced this issue Oct 4, 2018
@jrconlin
feat: make gcm calls use async callbacks
1dce0a5 
Closes #1291
jrconlin added a commit that referenced this issue Oct 5, 2018
@jrconlin
feat: make gcm calls use async callbacks
9b80416 
Closes #1291
jrconlin added a commit that referenced this issue Oct 6, 2018
@jrconlin
feat: make gcm calls use async callbacks
d67dcb4 
Closes #1291
@pjenvey
Copy link
Member

pjenvey commented Oct 8, 2018

Reopening as ADM still needs the same treatment

@pjenvey pjenvey reopened this Oct 8, 2018
@jrconlin
Copy link
Member Author

jrconlin commented Oct 9, 2018

👍 In big ways. I figured doing one bridge at a time would save y'all's sanity.

@jrconlin
Copy link
Member Author

Argh.

Looks like FCM introduced an "HTTP v1" that requires their admin console, a private key and what looks like a suite of HTTP2 calls to perform the actual message sends. Need to figure out the likelihood of them dropping the "legacy" access method in favor of only HTTP v1, if the HTTP/2 access also binds like requests does, and all the other fun things that this may bring.

@jrconlin jrconlin mentioned this issue Dec 13, 2018
Closed
jrconlin added a commit that referenced this issue Dec 13, 2018
@jrconlin
feat: Add FCM HTTPv1 API support
4efc7f6 
With the new FCM migration, it makes some sense to switch to the new
FCM HTTPv1 API. In addition, this uses twisted async.

Closes #1291
jrconlin added a commit that referenced this issue Dec 13, 2018
@jrconlin
feat: Use FCM HTTPv1 protocol with twisted async
e111ec1 
With the coming switch to FCM, it makes sense to also switch to the new
FCM HTTPv1 protocol.

Closes #1291
@jrconlin jrconlin mentioned this issue Dec 13, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
in progress p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjenvey @jrconlin @bbangert