This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: Use FCM HTTPv1 protocol with twisted async #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the coming switch to FCM, it makes sense to also switch to the new FCM HTTPv1 protocol. Closes #1291
Codecov Report
@@ Coverage Diff @@
## master #1308 +/- ##
==========================================
+ Coverage 99.79% 99.81% +0.01%
==========================================
Files 61 64 +3
Lines 9948 10673 +725
==========================================
+ Hits 9928 10653 +725
Misses 20 20
Continue to review full report at Codecov.
|
pjenvey
reviewed
Dec 20, 2018
autopush/router/fcmv1client.py
Outdated
| return d | ||
|
|
||
| def error(self, failure): | ||
| if isinstance(failure.value, FCMAuthenticationError) or \ |
There was a problem hiding this comment.
nit
Suggested change
| if isinstance(failure.value, FCMAuthenticationError) or \ | |
| if isinstance(failure.value, (FCMAuthenticationError, TimeoutError, ConnectError): |
autopush/router/fcmv1client.py
Outdated
| } | ||
| message = self._build_message(token, payload) | ||
| if 'timeout' not in self._options: | ||
| self._options['timeout'] = 3 |
There was a problem hiding this comment.
gcmclient also defaults to 3 but then gcm.py overwrites it with its own default of 10 (should we set this to 10 somewhere as too?)
There was a problem hiding this comment.
Well, GCM is different, and the value is only set to 10 if it's not already present, so it's more a backup than anything else. That said, I should be better about having a "global base timeout" value.
autopush/router/fcm_v1.py
Outdated
| status=401, | ||
| uri=kwargs.get('uri'), | ||
| senderid=repr(senderid)) | ||
| if not (senderid == self.senderID): |
There was a problem hiding this comment.
nit
Suggested change
| if not (senderid == self.senderID): | |
| if senderid != self.senderID: |
autopush/router/fcm_v1.py
Outdated
|
|
||
| def _process_reply(self, reply, notification, router_data, ttl): | ||
| """Process FCM send reply""" | ||
| # acks: |
There was a problem hiding this comment.
this comment's outdated (left over from gcm.py?)
jrconlin
force-pushed
the
feat/1291-fcm
branch
from
8ba0573
to
e4dc4f5
Compare
bbangert
reviewed
Dec 21, 2018
autopush/router/fcm_v1.py
Outdated
| def route_notification(self, notification, uaid_data): | ||
| """Start the FCM notification routing, returns a deferred""" | ||
| router_data = uaid_data["router_data"] | ||
| # Kick the entire notification routing off to a thread |
pjenvey
previously approved these changes
Dec 21, 2018
pjenvey
approved these changes
Dec 21, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the coming switch to FCM, it makes sense to also switch to the new
FCM HTTPv1 protocol.
Closes #1291