Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

JSONResponseError: 400 Bad Request part 2 #744

Closed
pjenvey opened this issue Nov 22, 2016 · 1 comment
Closed

JSONResponseError: 400 Bad Request part 2 #744

pjenvey opened this issue Nov 22, 2016 · 1 comment
Assignees
@bbangert
Labels
bug p1
Milestone
PUSHSVC-0: quality

Comments

@pjenvey
Copy link
Member

pjenvey commented Nov 22, 2016 •
edited by bbangert
Loading

Follow up to #703. Any db call can trigger these, so we need to handle it in more cases. Here's one triggered from a router:

https://sentry.prod.mozaws.net/operations/autopush-prod/issues/369293/

We need a fix similar to #718 covering other db calls
@pjenvey pjenvey added the bug label Nov 22, 2016
@pjenvey pjenvey added this to the PUSHSVC-0: quality milestone Nov 22, 2016
@pjenvey pjenvey added the ready label Dec 12, 2016
@bbangert bbangert added the p1 label Feb 9, 2017
@bbangert bbangert self-assigned this Mar 13, 2017
@bbangert bbangert removed their assignment Apr 14, 2017
@bbangert bbangert added in progress and removed ready labels May 3, 2017
@bbangert bbangert self-assigned this May 3, 2017
@bbangert
Copy link
Member

Most recent example:
https://sentry.prod.mozaws.net/operations/autopush-prod/issues/379820/

Solution that I'll submit handles JSONResponse as Provisioned error, as either way the system is not accepting the db call.

bbangert added a commit that referenced this issue May 11, 2017
@bbangert
feat: handle JSONResponse errors like provisioned errors
10287da 
When handling provisioned errors, the same logic should be used as when
a JSONResponseError occurs.

Closes #744
@bbangert bbangert mentioned this issue May 11, 2017
Merged
bbangert added a commit that referenced this issue May 11, 2017
@bbangert
feat: handle JSONResponse errors like provisioned errors
b70a47f 
When handling provisioned errors, the same logic should be used as when
a JSONResponseError occurs.

Closes #744
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
bug p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
2 participants
@pjenvey @bbangert