This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: handle JSONResponse errors like provisioned errors #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #892 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 54 54
Lines 9782 9780 -2
=====================================
- Hits 9782 9780 -2
Continue to review full report at Codecov.
|
pjenvey
suggested changes
May 11, 2017
autopush/web/base.py
Outdated
| @@ -236,7 +236,7 @@ def _overload_err(self, fail): | |||
|
|
|||
| def _boto_err(self, fail): | |||
| """errBack for random boto exceptions""" | |||
| fail.trap(BotoServerError) | |||
| fail.trap(BotoServerError, JSONResponseError) | |||
There was a problem hiding this comment.
not needed: JSONResponse is a BotoServerError subclass
autopush/router/simple.py
Outdated
| @@ -107,8 +108,8 @@ def route_notification(self, notification, uaid_data): | |||
| if result is False: | |||
| self.metrics.increment("router.broadcast.miss") | |||
| returnValue(self.stored_response(notification)) | |||
| except ProvisionedThroughputExceededException: | |||
| raise RouterException("Provisioned throughput error", | |||
| except (ProvisionedThroughputExceededException, JSONResponseError): | |||
There was a problem hiding this comment.
turns out ProvisionedThroughputExceededException is a subclass of JSONResponseError: so you could just catch that one
When handling provisioned errors, the same logic should be used as when a JSONResponseError occurs. Closes #744
pjenvey
approved these changes
May 11, 2017
jrconlin
reviewed
May 11, 2017
|
Yup, as @pjenvey pointed out. |
|
Apparently it is. |
jrconlin
approved these changes
May 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling provisioned errors, the same logic should be used as when
a JSONResponseError occurs.
Closes #744