Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Handle no "tiles" entry returned from adM #116

Closed
pjenvey opened this issue May 27, 2021 · 0 comments · Fixed by #117
Closed

Handle no "tiles" entry returned from adM #116

pjenvey opened this issue May 27, 2021 · 0 comments · Fixed by #117
Assignees
Labels
enhancement New feature or request

Comments

@pjenvey
Copy link
Member

pjenvey commented May 27, 2021

adM's API return an empty object without a "tiles" entry when there's no tiles to return, so we should expect this.

In the meantime let's emit a log message (probably temporarily) with the adM GET url/params for tracking when we get no results back for certain targeting parameters.

┆Issue is synchronized with this Jira Task

@pjenvey pjenvey added the enhancement New feature or request label May 27, 2021
@pjenvey pjenvey self-assigned this May 27, 2021
pjenvey added a commit that referenced this issue May 27, 2021
and log an error! for these (for now) so they show up in our stage/prod logs

Closes #116
jrconlin pushed a commit that referenced this issue May 27, 2021
and log an error! for these (for now) so they show up in our stage/prod logs

Closes #116
Trinaa pushed a commit that referenced this issue Jun 13, 2022
…ypes-requests-2.26.1

Bump types-requests from 2.26.0 to 2.26.1 in /client
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant