This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
feat: don't fail to decode on adM's empty response #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and log an error! for these (for now) so they show up in our stage/prod logs Closes #116
jrconlin
approved these changes
May 27, 2021
Trinaa
pushed a commit
that referenced
this pull request
Jun 13, 2022
…black-21.12b0 Bump black from 21.11b1 to 21.12b0 in /partner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
and log an error! for these (for now) so they show up in our stage/prod logs
Testing
Not easy to test this currently, we already return an empty response to the client. We can test this this change if we mock out sentry and allow feedback from it for tests
Issue(s)
Closes #116