Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Wire in Maxmind as the primary location lookup source #184

Closed
data-sync-user opened this issue Jun 23, 2021 · 4 comments · Fixed by #193
Closed

Wire in Maxmind as the primary location lookup source #184

data-sync-user opened this issue Jun 23, 2021 · 4 comments · Fixed by #193
Assignees
Labels
enhancement New feature or request

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jun 23, 2021

With us already seeing situations like #148 it makes sense to try out maxmind in case it results in less failed location lookups.

Let's finish wiring this into the app and use maxmind as the primary location lookup source, while still falling back to the LB header if it fails.

Let's ping SRE (@jbuck) on how to integrate the commercial version into contile.

┆Issue is synchronized with this Jira Task

@data-sync-user data-sync-user added the enhancement New feature or request label Jun 23, 2021
@data-sync-user
Copy link
Collaborator Author

➤ JR Conlin commented:

The code is already wired up to use the Max Mind database (if there is one defined in the maxminddb_loc setting), and will fail back to looking for the LB header if a lookup produces an error. We do not attempt to back fill from the Header and would need to add code if that is desired.

@data-sync-user
Copy link
Collaborator Author

@data-sync-user
Copy link
Collaborator Author

➤ Philip Jenvey commented:

This need some additional work ( #155 (comment) ) to follow up #155

@data-sync-user
Copy link
Collaborator Author

➤ JR Conlin commented:

The code is already wired up to use the Max Mind database (if there is one defined in the maxminddb_loc setting), and will fail back to looking for the LB header if a lookup produces an error. We do not attempt to back fill from the Header and would need to add code if that is desired.

pjenvey added a commit that referenced this issue Jun 23, 2021
- quiet clippy 1.53.0 warnings (#183)
- switch the empty tiles log message to warn! for now (disabling it on
  stage/prod w/ the ability to turn it back on)

Closes #184
pjenvey added a commit that referenced this issue Jun 23, 2021
- quiet clippy 1.53.0 warnings
- switch the empty tiles log message to warn! for now (disabling it on
  stage/prod w/ the ability to turn it back on)

Closes #183
Closes #184
Issue #178
pjenvey added a commit that referenced this issue Jun 24, 2021
- quiet clippy 1.53.0 warnings
- switch the empty tiles log message to warn! for now (disabling it on
  stage/prod w/ the ability to turn it back on)

Closes #183
Closes #184
Issue #178
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants