This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
Don't fallback on unknown subdivisions #148
Assignees
Labels
bug
Something isn't working
Comments
|
Confirmed we need empty strings here: "adM prefers us to leave it empty other than leaving it out or sending incorrect values. e.g. if somehow we don't know about the region-code, they want this ...&country-code=US®ion-code=&" |
pjenvey
added a commit
that referenced
this issue
Jun 15, 2021
only fallback on country (US) when no location info can be found and recognize mmdb's now always available in tests Closes #148
pjenvey
added a commit
that referenced
this issue
Jun 15, 2021
only fallback on country (US) when no location info can be found and recognize mmdb's now always available in tests Closes #148
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We're seeing clients with a country determined by the LB but not a subdivision, which we fallback to "OK", causing bogus adM parameters of e.g.
country-code=FR&subdivision=OK.Instead let's pass adM an empty subdivision if one cannot be determined, their service seems ok with this instead of a bogus value.
We likely still want a fallback country (US) in case it could not be determined.
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: