This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
feat: include ip addr for diagnosing mmdb lookup failures #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythmon
previously requested changes
Jun 14, 2021
| @@ -44,7 +44,12 @@ pub async fn get_tiles( | |||
| let addr = match ip_addr_str.parse() { | |||
| Ok(v) => v, | |||
| Err(e) => { | |||
| return Err(HandlerErrorKind::General(format!("Invalid remote IP {:?}", e)).into()); | |||
| // Temporary: log the IP addr for debugging mmdb issues | |||
| return Err(HandlerErrorKind::General(format!( | |||
There was a problem hiding this comment.
Since IPs are relatively sensitive information, should this be a configurable option that defaults to off? We could then turn it back off without having to cut a new release? (Or is there some other plan that isn't linked to from here?)
There was a problem hiding this comment.
I can but I'm not intending for this to be used outside of the dev env (or worse case stage if we don't reproduce it there).
I'm working on a change for #148 that will land shortly where I'll be intending to revert his
jbuck
approved these changes
Jun 14, 2021
mythmon
reviewed
Jun 14, 2021
Trinaa
pushed a commit
that referenced
this pull request
Jun 13, 2022
Add support for multiple API endpoints 📱
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Changes https://sentry.prod.mozaws.net/operations/contile/issues/11643624/?environment=dev
Issue(s)
Issue #149