Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Diagnose contile dev env failures #54

Closed
pjenvey opened this issue Apr 29, 2021 · 2 comments
Closed

Diagnose contile dev env failures #54

pjenvey opened this issue Apr 29, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@pjenvey
Copy link
Member

pjenvey commented Apr 29, 2021

Last week the contile dev env returned errors (but now it's working), let's take a look at logs and determine what was going wrong.

Dependent on more access to the project issue1708566

curl -v \
    -H User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0 \
    https://contile-dev.topsites.nonprod.cloudops.mozgcp.net/v1/tiles?country=US&placement=newtab
@pjenvey pjenvey added the bug Something isn't working label Apr 29, 2021
@pjenvey pjenvey self-assigned this Apr 29, 2021
@jrconlin
Copy link
Member

Hrm. Is there a log message we should capture here in case it falls out of sentry?

@pjenvey
Copy link
Member Author

pjenvey commented Apr 30, 2021

This is no longer happening, when it did happen on the 16th we saw these errors in the logs:

msg: "Internal Server Error: HandlerError { kind: Reqwest(reqwest::Error { kind: Decode, source: Error("missing field `tiles`", line: 1, column: 2) }), backtrace:    0: contile::web::handlers::get_tiles::{{closure}}
   1: <actix_web::handler::HandlerServiceResponse<T,R> as core::future::future::Future>::poll
   2: <actix_web::handler::ExtractResponse<T,S> as core::future::future::Future>::poll
   3: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
   4: <futures_util::future::future::Map<Fut,F> as core::future::future::Future>::poll
   5: <core::pin::Pin<P> as core::future::future::Future>::poll
   6: <futures_util::future::either::Either<A,B> as core::future::future::Future>::poll
   7: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
   8: <futures_util::future::future::map::Map<Fut,F> as core::future::future::Future>::poll
   9: <futures_util::future::try_future::try_flatten::TryFlatten<Fut,<Fut as futures_core::future::TryFuture>::Ok> as core::future::future::Future>::poll
  10: <futures_util::future::try_future::AndThen<Fut1,Fut2,F> as core::future::future::Future>::poll
  11: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
  12: actix_http::h1::dispatcher::InnerDispatcher<T,S,B,X,U>::poll_response
  13: <actix_http::h1::dispatcher::Dispatcher<T,S,B,X,U> as core::future::future::Future>::poll
  14: <actix_service::and_then::AndThenServiceResponse<A,B> as core::future::future::Future>::poll
  15: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
  16: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
  17: tokio::runtime::task::harness::Harness<T,S>::poll
  18: std::thread::local::LocalKey<T>::with
  19: tokio::task::local::LocalSet::tick
  20: <tokio::task::local::RunUntil<T> as core::future::future::Future>::poll
  21: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
  22: std::thread::local::LocalKey<T>::with
  23: tokio::macros::scoped_tls::ScopedKey<T>::set
  24: tokio::runtime::basic_scheduler::BasicScheduler<P>::block_on
  25: tokio::runtime::context::enter
  26: std::sys_common::backtrace::__rust_begin_short_backtrace
  27: core::ops::function::FnOnce::call_once{{vtable.shim}}
  28: <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/alloc/src/boxed.rs:1307:9
      <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once
             at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/alloc/src/boxed.rs:1307:9
      std::sys::unix::thread::Thread::new::thread_start
             at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/std/src/sys/unix/thread.rs:71:17
  29: start_thread
  30: clone

I'm closing this and logging a new issue for this stack trace.

@pjenvey pjenvey closed this as completed Apr 30, 2021
jrconlin added a commit that referenced this issue May 3, 2021
ADM can sometimes return invalid content (e.g. a 200 response with no
"tiles".

Report this to sentry, and log, but we return an "empty" value to the
client.

Closes #54
pjenvey pushed a commit that referenced this issue May 6, 2021
* bug: handle bad responses from ADM

ADM can sometimes return invalid content (e.g. a 200 response with no
"tiles".

Report this to sentry, and log, but we return an "empty" value to the
client.

Closes #54
Trinaa pushed a commit that referenced this issue Jun 13, 2022
…ypes-pyyaml-5.4.6

Bump types-pyyaml from 5.4.3 to 5.4.6 in /partner
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants