This repository has been archived by the owner on Jul 26, 2024. It is now read-only.
bug: handle bad responses from ADM #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADM can sometimes return invalid content (e.g. a 200 response with no "tiles". Report this to sentry, and log, but we return an "empty" value to the client. Closes #54
pjenvey
suggested changes
May 3, 2021
pjenvey
previously approved these changes
May 4, 2021
pjenvey
approved these changes
May 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ADM can sometimes return invalid content (e.g. a 200 response with no
"tiles".
Report this to sentry, and log, but we return an "empty" value to the
client.
Testing
A bit difficult, since this will query the ADM service directly. It's possible to use an external service which returns an invalid response value (e.g.
and set the
CONTILE_ADM_ENDPOINT="http://localhost:8080"*Note, this is an example only. the response may not be fully valid HTTP
Issue(s)
Closes #55