OBS-361: Remove tini and set up stop signals. #6771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tini process was originally added to make Docker comtainers quite properly when receiving the TERM signal on
docker compose stop. Some containers don't react to this signal, so terminating them will hang for ten seconds before Docker Compose sends SIGKILL.The changes in this PR are similar to mozilla-services/tecken#3049.
I added
execto run the main command to a bunch of shell scripts. This ensures the shell script doesn't linger around, and the actual main process receives the signals, which is a lot more useful.https://mozilla-hub.atlassian.net/browse/OBS-361